search

Bertverbeek4PS / bc2adls

Exporting data from Dynamics 365 Business Central to Azure data lake storage or MS Fabric lakehouse
MIT License
60 stars 22 forks source link

Introduce MaximumLength properties on Attribute within common data model #85

Closed acjdekorte closed 9 months ago

acjdekorte commented 9 months ago

Introduced maximumLength property on Attribute within common data model, so when creating a sql database from the azure data lake it is possible to create keys. Create keys on sql level is not possible on fields of type NVARCHAR(MAX).

From the documentation on https://learn.microsoft.com/en-us/common-data-model/ , it is not completely clear if this the correct place to include the property. Based on https://github.com/microsoft/CDM/blob/master/samples/example-public-standards/schema.cdm.json, I think that it is.

Bertverbeek4PS commented 9 months ago

Thanks! @acjdekorte it looks indeed the correct place for me also. Have you tried to connect to the PowerBI app? Because Power BI is also reading the CDM schema. So need to be sure if this change would not break anything. Otherwise I will test it.

acjdekorte commented 9 months ago

@Bertverbeek4PS No, I have not tested in combination PowerBI App.

Bertverbeek4PS commented 9 months ago

@acjdekorte I have tested it and everything works fine! Thanks for the contribution! Really appreciate it!

acjdekorte commented 9 months ago

@Bertverbeek4PS Thank you for the quick review