Besac1 / gource

Automatically exported from code.google.com/p/gource
0 stars 0 forks source link

Removed files are still being displayed #206

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Make a commit where you add and delete a lot of different files. In example 
changing the entire folder structure of your project.
2. Then gource on the rep
(See https://github.com/BrainStone/brainstone/ as a working example (Last few 
commits. And I also noted some files that should have been removed months ago!)

What is the expected output? What do you see instead?
The all files that have been removed or moved should no longer be displayed in 
their old spot.
But some (very few only 2 out of over 45) files are still in the old spot and 
the new one!

What version of the product are you using? On what operating system?
0.40 on Win XP Sp3

Original issue reported on code.google.com by brainsto...@gmail.com on 5 Nov 2013 at 7:06

GoogleCodeExporter commented 8 years ago
More information:

This is likely to happen when the seconds per day setting is low.

It might occur, that in the log a file gets edited then deleted. But when 
gource first deletes it and the edits it, the file will not diappear.

This is a bug that needs to be fixed!

Original comment by brainsto...@gmail.com on 20 Nov 2013 at 10:39

GoogleCodeExporter commented 8 years ago
Will look into it. Thanks for the report.

Original comment by acaudw...@gmail.com on 21 Nov 2013 at 2:34

GoogleCodeExporter commented 8 years ago
Can you give me an example of a particular file that isn't removed and also a 
seconds per day value that produces this effect? Thanks.

Original comment by acaudw...@gmail.com on 21 Nov 2013 at 3:26

GoogleCodeExporter commented 8 years ago
Rep: https://github.com/BrainStone/brainstone/
SecPerDay: 1
File (example): brainstonemod/block/BrainStoneBlockHiders.java

(At the very end)

Another good (and short) repo: 
https://github.com/BrainStone/HAG-Robotic-Night-Bibliothek

Settings like 5 seconds per day are fine. But settings arround 1 seconds per 
day mess it up!

I hope this helps!

Original comment by brainsto...@gmail.com on 21 Nov 2013 at 4:16

GoogleCodeExporter commented 8 years ago
It looks like the issue may be around files being removed in resolving of a 
merge conflict. git log doesn't seem to produce a 'delete' entry for the files 
removed.

'brainstonemod/blocks/BlockBrainStoneHiders.java' is included in the commit 
aa2c9406baba399f87af312beaffd993f4e9849a, and appears the list of merge 
conflicts in the commit 8d6fa526b5b4a9374e9154b9266767b27d482404, but not in 
the list of files associated with that commit.

Original comment by acaudw...@gmail.com on 23 Jan 2014 at 2:11

GoogleCodeExporter commented 8 years ago
I am seeing this behavior.  However, I'm using a custom log format generator 
which appears to generate all removes correctly.  Also, it isn't deterministic 
which files may or may not be left around.  It appears to me, when there are 
several users modifying the same file the visualization can trigger a user to 
beam and modify a file after the delete beam happens causing the file to stick 
around in the visualization.  I added my custom log file, it is easiest to see 
the problem if you load it up, and hold 'n' and then let go in June.  All the 
red files will be files that should have been removed.  I'm on windows v .042 
using the command line: `gource -a 1 -s 2 -i 0 --title YNAB --log-format custom 
custom.log`

Original comment by beeblebr...@gmail.com on 14 Dec 2014 at 8:14

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the test data.

Original comment by acaudw...@gmail.com on 15 Dec 2014 at 4:01