BeshoyAtef / Terasoft_14

1 stars 0 forks source link

Notify user #189

Closed youssefbarakat closed 10 years ago

youssefbarakat commented 10 years ago

please review my code @hagaressam @YoussefSaleh @mohamed-khairy @Ahmedheshamnasser @sharkas911 #139

youssefbarakat commented 10 years ago

@mohamed-khairy thanks :) check again now

hagaressam commented 10 years ago

Documentation reviewed

mohamed-khairy commented 10 years ago

The second commit is reviewed for implementation and accepted

Ahmedheshamnasser commented 10 years ago

@youssefbarakat your story doesnt have a success or failure scenarios so is it only view the notification page or view the page and the notifications too ? if it only show the page without anything else then the scenario is verified if not then its not verified because i inserted in the database and it didnt show the notifications only the page

youssefbarakat commented 10 years ago

@Ahmedheshamnasser my story requires view notification page and i did an additional methods for inserting notifications into the table

YoussefSaleh commented 10 years ago

@youssefbarakat plz tell me the routes to check it

Ahmedheshamnasser commented 10 years ago

@youssefbarakat i inserted in the database the user_id and a description and showed in the notification page scenario reviewed

sharkas911 commented 10 years ago

implementation reviewed