mariowadiee commented 10 years ago

222 @rehab-arafa @joewagieh @youssefbarakat @madeleine92 @mariam-elsanady

joewagieh commented 10 years ago

@mariowadiee There is no documentation for your html file check it again

youssefbarakat commented 10 years ago

Shipme_proj/app/models/payment.rb the indentation in this file is not 2,and def update

sid = params[:sid]
cid = params[:cid]
@pack.to_a.each do|p|
@p = Packages.get_packages_payments(sid,cid)
@sender = Users.get_sender_payments(sid)
@carry = Users.get_carrier_payments(cid)
@sender.to_a.each do|s|
if (s.creditCard - ( @p.carryingPrice * Configurations.find(:all).last().comission)) < 0
@salout = "your sender credit card balance is not enough"
redirect_to :action => 'notify', :salout => @salout
return
else
@saleout2 = "your credit card is accepted"
redirect_to :action => 'withdraw', :salout => @salout2
end
@carry.to_a.each do|c|
if c.creditCard - p.packageValue<0
@salout = "your carrier credit card balance is not enough"
redirect_to :action => 'notify', :salout => @salout
return
else
@saleout2 = "your credit card is accepted"
redirect_to :action => 'withdraw', :salout => @salout2
end
@value = s.creditCard - ( p.carryingPrice * Configurations.find(:all).last().comission)
Users.update_creditcard(@sender,@value)
@value2 = c.creditCard - p.packageValue
Users.update_creditcard(@carry,@value2)
@sender.delete
@carry.delete
end
@pay = Payment.get_packages_payments(sid)
@pay.packageid = @pack.id
@value_payment = ( p.carryingPrice * Configurations.find(:all).last().comission)+ p.packageValue
Payment.update(p,2000,id)
Payment.amountWithdraw = @value_payment
@pay.save
@sender.save
@carry.save
end
end
end adjust the closing end with its if or loop also, check your implementation again

mariowadiee commented 10 years ago

@youssefbarakat youssef please check i have updated the code thank you

mariowadiee commented 10 years ago

@joewagieh Thank you please review it again

BeshoyAtef / Terasoft_14