BestImageViewer / geeqie

claiming to be the best image viewer / photo collection browser
http://www.geeqie.org/
GNU General Public License v2.0
470 stars 77 forks source link

Looking at images in multiple directories opens extra windows and asks extra questions #1056

Open dkogan opened 1 year ago

dkogan commented 1 year ago

ISSUE TYPE

GEEQIE VERSION

Geeqie 2.0.1 GTK3

but this happens in a bleeding edge build as well

OS / DISTRIBUTION

Debian/sid.

SUMMARY

This was mentioned in #862, but I want to open a separate issue for this. Normally you geeqie a.jpg b.jpg. It shows the images in a window. You close the window, and you're done. But if you geeqie dir1/a.jpg dir2/b.jpg it also opens some other window (collection), and when you exit, it pops up a "Collections have been modified. Quit anyway?" dialog. There should be no difference in behavior in the two cases. I'm just looking at some images, and I told geeqie where they are. I never want a "collection" window, and I never want the extra dialog. But if I DID want a collection window, I'd be complaining that I don't get one if the files are in the same directory. The behavior should be the same.

Thanks.

caclark commented 1 year ago

At the moment (i.e. when I feel in the mood) I am looking at changing the way in which collections are handled.

I intend that collections will appear in the directories pane as pseudo sub-dirs under some point or other, and the icons pane will show the contents of the collection. The main image pane will show whichever icon has the focus.

Clicking on a collection psuedo sub-dir will open the collection, in the same way a normal directory is opened. Opening more than one collection at the same time will result in a second Geeqie window opening, as for opening a second directory to view.

Modifying/writing to a collection will be as for a directory - it happens immediately. Possibly without any requirement for user confirmation, unless the action is potentially disastrous.

I feel inclined to not save any collection titled Untitled - treat them as being in /tmp. I sometimes create them as a temporary convenience when looking at a set of files, then discard the collection. If the user wants to save a collection it should be explicitly named.

So in the case of an Untitled collection being automatically created from the command line, if you don't explicitly save it you lose it.

dkogan commented 1 year ago

Sounds good. Thanks.