BestImageViewer / geeqie

claiming to be the best image viewer / photo collection browser
http://www.geeqie.org/
GNU General Public License v2.0
466 stars 77 forks source link

Toolbar looks fixed, but actions don't work before opening preferences once #1462

Open gusnan opened 1 month ago

gusnan commented 1 month ago

Setup (please complete the following information):

Describe the bug The fix for the bug #1450 seems to have fixed the looks of the buttons and part of the behavior, many thanks for that - BUT, now that it works I have discovered that it doesn't work correctly until I go to preferences (I don'ẗ even need to go to the toolbar preferences tab, just open the preferences window) and press OK to apply them before it works properly. Before I do this, pressing a plugin toolbar button just gives

(geeqie:74135): Gtk-CRITICAL **: 18:32:37.349: gtk_action_activate: assertion 'GTK_IS_ACTION (action)' failed

in a terminal, but no action. After going to the preferences, pressing OK to apply them, the toolbar plugin button works just fine. Doing some research it looks like the function config_window_apply() in preferences.cc calls toolbar_apply(TOOLBAR_MAIN), which isn't called before this, this might be related. This might be a config thing specific to my setup, but I kind of doubt it.

To reproduce See above ^.

Expected behavior Toolbar plugin buttons working without having to go to preferences first to make it work.

gusnan commented 1 month ago

And to make things clearer, the problem seems to be only for plugin buttons.

caclark commented 1 month ago

@gusnan Thanks. I see the problem, but did not yet find a solution.