search

BestImageViewer / geeqie

claiming to be the best image viewer / photo collection browser
http://www.geeqie.org/
GNU General Public License v2.0
488 stars 79 forks source link

Performs a secondary cleanup attempt in `isolate-test.sh` in case the first one fails #1533

Closed xsdg closed 2 weeks ago

xsdg commented 4 weeks ago

This works around a race condiditon that occurs reliably when the xdg-desktop-portal package is installed.

When this triggers, the output looks like:

$.../scripts/isolate-test.sh .../scripts/image-test.py .../build/src/geeqie .../build/test-images.p/images/JPG_MINOLTA_RD175.JPG
Variables in isolated environment:
G_DEBUG=fatal-critical
HOME=/tmp/tmp.uCSyUTWVkw
XDG_CONFIG_HOME=/tmp/tmp.uCSyUTWVkw/.config
XDG_RUNTIME_DIR=/tmp/tmp.uCSyUTWVkw/.runtime
DBUS_SESSION_BUS_ADDRESS=unix:path=/tmp/dbus-Nou8YYvYti,guid=9de5a10c77563265a7e1c9b167214161

[...]
Warning: Failed to convert Exif.Photo.DateTimeOriginal to Xmp.photoshop.DateCreated, unable to parse '19ff:1f:3f 3f:7f:00'
Warning: Failed to convert Exif.Photo.DateTimeDigitized to Xmp.xmp.CreateDate, unable to parse '19ff:1f:3f 3f:7f:00'
rm: cannot remove '/tmp/tmp.uCSyUTWVkw/.runtime/doc': Is a directory

First cleanup attempt failed; sleeping and retrying...
removed directory '/tmp/tmp.uCSyUTWVkw/.runtime/doc'
removed directory '/tmp/tmp.uCSyUTWVkw/.runtime'
removed directory '/tmp/tmp.uCSyUTWVkw'

Fixes #1532

caclark commented 2 weeks ago

Implemented in commit 9e5a7eb215d70a529602ae152ecccc078489cf61