BestImageViewer / geeqie

claiming to be the best image viewer / photo collection browser
http://www.geeqie.org/
GNU General Public License v2.0
488 stars 79 forks source link

Runtime end-fo-life #1537

Closed nk8020 closed 2 weeks ago

nk8020 commented 3 weeks ago

Setup (please complete the following information):

Describe the bug Reported EoL for the gnome runtime (gnome 45)

To reproduce Install & get it automatically

Expected behavior Opens up security update problems

Screenshots If applicable, add screenshots to help explain your problem. 11

Image sources Flathub

URGENT !! It Is my favorite photo viewer by far.

caclark commented 2 weeks ago

I think this may be a Flathub problem:

https://github.com/flathub/org.geeqie.Geeqie

richardstevenhack commented 2 weeks ago

Same problem on openSUSE Tumbleweed.

The GNOME 45 platform is no longer supported. Flatpak offers version 47. https://flathub.org/apps/org.gnome.Platform

caclark commented 2 weeks ago

I am confused as to what is happening here with .

If there is a problem with a FlatPak, I think that raising the issue on https://github.com/flathub/org.geeqie.Geeqie would be best.

richardstevenhack commented 2 weeks ago

It is NOT an issue with the flatpak. You developed Geeqie to run on Flatpak, did you not? Or did someone else do that? I'm not familiar on who does Flatpak development, either the original author or someone else. In any event, it's your program so I'm addressing the issue to you.

The GNOME Platform for which Geeqie was developed on Flatpak is version 45. That version has security issues and has been retired. Current version is 47. Therefore it is logical that the Flatpak version should be modified to use the correct platform.

I don't know if that's you or someone else. I'm just pointing this out.

qarkai commented 2 weeks ago

Same problem on openSUSE Tumbleweed.

It doesn't matter where Flatpak is running.

It is NOT an issue with the flatpak.

It is. Not the whole Flatpak system, just one obsolete package. Hint: https://github.com/flathub/org.geeqie.Geeqie/blob/a79d54e5aa8ca696dd1a672d02693854a152c0db/org.geeqie.Geeqie.json#L4

You developed Geeqie to run on Flatpak, did you not?

Nope.

Or did someone else do that?

Yep. @caclark has already provided the link twice: https://github.com/flathub/org.geeqie.Geeqie

I'm not familiar on who does Flatpak development, either the original author or someone else.

It doesn't matter who the person is, you should choose proper project for raising issues.

In any event, it's your program so I'm addressing the issue to you.

Again, it's the packager's issue, usually called "downstream". Address it to https://github.com/flathub/org.geeqie.Geeqie


@caclark I'd close this issue.

caclark commented 2 weeks ago

The project github.com/BestImageViewer/geeqie/ provides only source code (although in recent times I have additionally included code to auto-generate AppImages within this project). The source code is taken by various packagers e.g Debian, Flatpak etc., to create something for users.

As @qarkai has commented, the Flatpak failure should be reported to the Geeqie/Flatpak project.

The near-simultaneous failure of Geeqie's Flatpaks and AppImages is just a coincidence.

At around the same time that the GNOME 45 platform was obsoleted, I updated the GitHub runner used to create the AppImages from Ubuntu 22.04 to 24.04, and that caused the AppImages to fail.

I used AppImageCrafters / appimage-builder to generate the AppImages, and that is where I think the problem lies. Rather than wait for that project to be updated, I will use another method - and that may take a little while.

nk8020 commented 2 weeks ago

This discussion was interesting, though I would appreciate an answer:

Q: does the Geeqie code (flatpak or not) rely on a genome 45 runtime? -If so, it has a fast approaching security issue anyways.

If you say that the flatpak has this problem but the Geeqie code doesn't hold any specific runtime environment dependency, It's a hole other ballgame.

I would appreciate a clear and concise answer, as to where the environment dependency stems from..

Thanks

qarkai commented 2 weeks ago

Q: does the Geeqie code (flatpak or not) rely on a genome 45 runtime?

No, Geeqie depends on particular libraries GTK, GLib, etc. AFAIU GNOME platform/runtime is Flatpak-specific.

nk8020 commented 2 weeks ago

Q: does the Geeqie code (flatpak or not) rely on a genome 45 runtime?

No, Geeqie depends on particular libraries GTK, GLib, etc. AFAIU GNOME platform/runtime is Flatpak-specific.

Thank you Qarkai, Then, essentially, if I decide to dispense of the flatpak and install it as a native package, it should run fine, and not have this vuln, if I get it.. If I understand correctly, glib is essential to all or most debian-based distros, and is maintained, though don't know about GTK (seems more and more a move to Qt). GTK is maintained by Gnome Environment tough, so there is this dependency anyways, and it just might shed light on the issue - Could you help me understand if the GTK dependency might be the cause of this Gnome 45 issue? (after all, it's a runtime issue, so might be in "legacy" code..)

qarkai commented 2 weeks ago

GNOME 45 is not maintained https://release.gnome.org/calendar/, GTK3 is still maintained https://en.wikipedia.org/wiki/GTK#Releases:~:text=3%2B%20years%0A3.22.29-,3.24,-2018%2D09%2D03. So it's not a technical issue, rather manager's decision.

qarkai commented 2 weeks ago

if I decide to dispense of the flatpak and install it as a native package, it should run fine

Note that flatpak application's cache-config-data files could be somewhere in flatpak's directories. When you run native package application it usually creates and searches for them in XDG-based directories, i.e. ~/.cache/<app>, ~/.config/<app>, ~/.local/share/<app>, etc.

nk8020 commented 2 weeks ago

So if I understand what you're saying.. -I should definitely ditch the flatpak for the native, and further follow the project, as GTK3 seems VERY old, and even GTK4 has been around since 2020..

richardstevenhack commented 2 weeks ago

Thanks all for the clarifications. I have opened an issue with the flatpak maintainer.