BestImageViewer / geeqie

claiming to be the best image viewer / photo collection browser
http://www.geeqie.org/
GNU General Public License v2.0
479 stars 79 forks source link

[raw file] -> External Editor -> RawTerapee can't be started #518

Closed ff2000 closed 7 years ago

ff2000 commented 7 years ago

I get the error dialog

External command failed

Can't find matching file type.
Unable to start external command.

Editor->Darktable works fine but I am used to RawTherapee (and like its output more).

I used geeqies last stable release but also tried most recent git master.

caclark commented 7 years ago

It may relate to the conversion table at line 109 in editors.c - it's probably out of date, and doesn't contain the mime types used in the rawtherapee.desktop file. I don't know about this subject, so I'm not in a position to fix it. But for sure if you create your own desktop file for rawtherape, with the mime types you use, you can get rawtherapee to be called.

caclark commented 7 years ago

Fixed in commit b51727968 at geeqie.org

pittendrigh commented 6 years ago

It's September 2018 and I have this problem. I had this working but recently rebuilt with Mint Linux Tara. And now it's broken again, for Nikon *.NEF files. I removed the the apt-get version and built the latest geeqie from source. Still no satisfaction. A dialog pops up complaining about matching file type.

I am running rawtherapee as /usr/local/bin/RawTherapee-dev-5.4-792-g3643e15.AppImage ...with /usr/local/bin/rawtherapee as a symbolic link to RawTherapee-dev-5.4-792-g3643e15.AppImage

Is there an environment variable hassle with AppImage executables?

caclark commented 6 years ago

Could you go to Edit/Configure Plugins and check that the desktop file for RawTherapee contains: image/x-nikon-nef; That is the most likely cause for that error message.

pittendrigh commented 6 years ago

MimeType=image/jpeg;image/png;image/tiff;image/x-adobe-dng;image/x-canon-cr2;image/x-canon-crf;image/x-canon-crw;image/x-fuji-raf;image/x-hasselblad-3fr;image/x-hasselblad-fff;image/x-jpg;image/x-kodak-dcr;image/x-kodak-k25;image/x-kodak-kdc;image/x-leaf-mos;image/x-leica-rwl;image/x-mamiya-mef;image/x-minolta-mrw; image/x-nikon-nef; image/x-nikon-nrw;image/x-olympus-orf;image/x-panasonic-raw;image/x-panasonic-rw2;image/x-pentax-pef;image/x-pentax-raw;image/x-phaseone-iiq;image/x-raw;image/x-rwz;image/x-samsung-srw;image/x-sigma-x3f;image/x-sony-arq;image/x-sony-arw;image/x-sony-sr2;image/x-sony-srf;image/x-tif;

On Wed, Sep 5, 2018 at 10:11 AM Colin Clark notifications@github.com wrote:

Could you go to Edit/Configure Plugins and check that the desktop file for RawTherapee contains: image/x-nikon-nef; That is the most likely cause for that error message.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BestImageViewer/geeqie/issues/518#issuecomment-418789116, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6TX6cubZBt6Tn7ziFeq2UNozR5-vleks5uX_emgaJpZM4PgihG .

-- / Colin (Sandy) Pittendrigh >--oO0> /

caclark commented 6 years ago

It is not a problem with AppImages - the problem occurs within Geeqie before the external program is called. I am not able to replicate this problem with my setup. There are two ways to call a plugin - form the main menu, and from a right-click on a thumbnail. Could you please check both. If Rawtherapee does not appear in the right-click menus, it indicates a problem with the mime-types in the .desktop file. Could you also check, just to be sure, that this only applies to .nef raw files and not to e.g .cr2 files?

pittendrigh commented 6 years ago

Ok. Back from work. In a test directory I copied blue_horse.nef as mess.NEF and as mess.cr2.

I started geeqie compiled from geeqie-1.3.tar.xz Right click on a thumbnail produces a popup (I couldn't figure out how to use import to capture a popup) that contains no opportunity to spawn any other program.

I had fiddled with those sources so I removed them and un-tarred fresh from geeqie-1.3.tar.xz. Autogenned the sources and made it again. No change.

So I blew away that geeqie and used sudo apt-get install geeqie to get a slightly older version. Same behavior.

On a hunch I blew away ~/.config/geeqie and started again. Still no change.

I must be doing something stupid. But I don't know what it is.

On Thu, Sep 6, 2018 at 3:23 AM Colin Clark notifications@github.com wrote:

It is not a problem with AppImages - the problem occurs within Geeqie before the external program is called. I am not able to replicate this problem with my setup. There are two ways to call a plugin - form the main menu, and from a right-click on a thumbnail. Could you please check both. If Rawtherapee does not appear in the right-click menus, it indicates a problem with the mime-types in the .desktop file. Could you also check, just to be sure, that this only applies to .nef raw files and not to e.g .cr2 files?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BestImageViewer/geeqie/issues/518#issuecomment-419026466, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6TXxLMECNt1BC4Krf9zXZyFLgPwRHPks5uYOmagaJpZM4PgihG .

-- / Colin (Sandy) Pittendrigh >--oO0> /

caclark commented 6 years ago

The right-click menu has an item at the top - "Edit" (the label is erroneous - it should be "Plugins". Some time ago I changed Editors to Plugins, as that seems more appropriate description - I missed that menu label at the time).

You can eliminate mime-type problems by commenting out (use the # character) the MimeType line in the .desktop file - Edit/Configure Plugins. That should get something to work, but does not identify the problem.

Instead try including the line: X-Geeqie-Verbose=true

in the .desktop file. The resulting dialogue should give more information about what is missing.

pittendrigh commented 6 years ago

Ah. Just got in again. I seem to be getting much the same geeqie1.3 from both sudo apt-get install geeqie and building from the geeqie-1.3.tar.xz I downloaded a few days ago.

When I make a test directory with a variety of image types, if I right click on the thumbnail for a jpeg (mess.jpg) I see a popup menu with a variety of executable options including rawtherapee and gimp.

If I right click on a jpeg thumbnail and choose gimp I'm in good shape. Gimp starts with that jpeg image. This also works from the top menu bar as edit->external-editors->gimp

If a mess.nef (which is a nikon raw file) if I use top menu bar edit->external-editors->rawthreapee I see the "External Command Failed -- can't find matching file type" menu.

If I right click on the mess.nef thumbnail I see a popup that includes only three options, two import metadata options and symlink, but no option for Gimp and no option rawtherapee (which did appear in top menu bar dropdown)

======== Finally, in /home/me/.config/geeqie/applications/appimagekit-rawtherapee.desktop if I comment out the MimeTypes line i do get different behavior.

Now, for any image file suffix I can think of I can right click on the thumbnail and see rawtherapee as an option. If I choose rawtherapee on a real nikon raw file nothing happens GUI-land but an error message appears in the terminal I started geeqie from:

/usr/lib/gimp/2.0/plug-ins/file-rawtherapee/file-rawtherapee is a GIMP plug-in and must be run by GIMP to be used

On Fri, Sep 7, 2018 at 4:43 AM Colin Clark notifications@github.com wrote:

The right-click menu has an item at the top - "Edit" (the label is erroneous - it should be "Plugins". Some time ago I changed Editors to Plugins, as that seems more appropriate description - I missed that menu label at the time).

You can eliminate mime-type problems by commenting out (use the # character) the MimeType line in the .desktop file - Edit/Configure Plugins. That should get something to work, but does not identify the problem.

Instead try including the line: X-Geeqie-Verbose=true

in the .desktop file. The resulting dialogue should give more information about what is missing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BestImageViewer/geeqie/issues/518#issuecomment-419400687, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6TX0lZhCaG4zhO5h4OTT7XvKlVGk6Uks5uYk2-gaJpZM4PgihG .

-- / Colin (Sandy) Pittendrigh >--oO0> /

caclark commented 6 years ago

Your RawTherapee .desktop file should have the line: Exec=rawtherapee %f

Could you check where the exec line is pointing to?

pittendrigh commented 6 years ago

Ouch. In an earlier reply I did say "I must be doing something stupid but I don't know what it is"

My raw rawtherapee (which runs properly directly from the command line) is: /usr/local/bin/RawTherapee-dev-5.4-792-g3643e15.AppImage

I also have a symbolic link in /usr/local/bin pointing "rawtherapee" to the AppImage

The original Exec entry, as created by sudo apt-get install, was: Exec="/usr/lib/gimp/2.0/plug-ins/file-rawtherapee/file-rawtherapee" --remove-appimage-desktop-integration

I experimented with various combinations of removing --remove-appimage-desktop-integration and/or adding a $1 before the second double quote. I didn't try adding %f It didn't occur to me. I just did now change the Exec line to:

Exec="/usr/local/bin/rawtherapee %f" ##using the symlink

...and then: Exec="/usr/local/bin/RawTherapee-dev-5.4-792-g3643e15.AppImage"

In both cases I see the terminal window message: /usr/lib/gimp/2.0/plug-ins/file-rawtherapee/file-rawtherapee is a GIMP plug-in and must be run by GIMP to be used

...which is strange. This must be some sort of an environment hassle?

On Sat, Sep 8, 2018 at 3:20 AM Colin Clark notifications@github.com wrote:

Your RawTherapee .desktop file should have the line: Exec=rawtherapee %f

Could you check where the exec line is pointing to?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BestImageViewer/geeqie/issues/518#issuecomment-419626277, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6TX_opAiK6wTRsgZ-eMBAWspSFC7MLks5uY4v5gaJpZM4PgihG .

-- / Colin (Sandy) Pittendrigh >--oO0> /

pittendrigh commented 6 years ago

Solved. Sorry to have wasted so much of your time.

Stupid? I had been editing the remove Exec. I worked with the first Exec line in the config file and got it fixed.

However, the original as per installed Exec line was: Exec="/path/path/path/path/rawtherapee " %U

To get the spawn to work I changed the above to: Exec="/usr/local/bin/rawtherapee " %f

And that worked. Perhaps I qualify as one of those who know enough about the unix environment to get in trouble. But not to fix things. I'm retired. 70 now. I worked in unix server-side coding but never did anything with desktop GUI applications.

That did not work for me.

On Sat, Sep 8, 2018 at 5:47 AM Colin (Sandy) Pittendrigh < sandy.pittendrigh@gmail.com> wrote:

Ouch. In an earlier reply I did say "I must be doing something stupid but I don't know what it is"

My raw rawtherapee (which runs properly directly from the command line) is: /usr/local/bin/RawTherapee-dev-5.4-792-g3643e15.AppImage

I also have a symbolic link in /usr/local/bin pointing "rawtherapee" to the AppImage

The original Exec entry, as created by sudo apt-get install, was: Exec="/usr/lib/gimp/2.0/plug-ins/file-rawtherapee/file-rawtherapee" --remove-appimage-desktop-integration

I experimented with various combinations of removing --remove-appimage-desktop-integration and/or adding a $1 before the second double quote. I didn't try adding %f It didn't occur to me. I just did now change the Exec line to:

Exec="/usr/local/bin/rawtherapee %f" ##using the symlink

...and then: Exec="/usr/local/bin/RawTherapee-dev-5.4-792-g3643e15.AppImage"

In both cases I see the terminal window message: /usr/lib/gimp/2.0/plug-ins/file-rawtherapee/file-rawtherapee is a GIMP plug-in and must be run by GIMP to be used

...which is strange. This must be some sort of an environment hassle?

On Sat, Sep 8, 2018 at 3:20 AM Colin Clark notifications@github.com wrote:

Your RawTherapee .desktop file should have the line: Exec=rawtherapee %f

Could you check where the exec line is pointing to?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BestImageViewer/geeqie/issues/518#issuecomment-419626277, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6TX_opAiK6wTRsgZ-eMBAWspSFC7MLks5uY4v5gaJpZM4PgihG .

-- / Colin (Sandy) Pittendrigh >--oO0> /

-- / Colin (Sandy) Pittendrigh >--oO0> /

caclark commented 6 years ago

You are using a -dev- version of the AppImage, and I cannot find that version anywhere to download. Perhaps you could try the latest AppImage from RawTherapee, or the latest -dev- version from elsewhere.

By the way, I don't put a path in the call to RawTherapee in the desktop file - just the program name - and relay on the PATH environment variable to take care of things.

So, if I type on a command line I get: cclark@Asus:~/Desktop$ which rawtherapee /usr/bin/rawtherapee

And then: cclark@Asus:~/Desktop$ ls -l /usr/bin/rawtherapee lrwxrwxrwx 1 root root 56 Sep 6 10:01 /usr/bin/rawtherapee -> /home/cclark/Downloads/RawTherapee-releases-5.4.AppImage

caclark commented 6 years ago

OK, I've just seen your response. No problem.

retired. 70 now. I worked

Yeah, I remember 8-track paper tape too!