search

BestOwl / MyPhone

Connect your mobile devices (Android/iOS/WindowsPhone) to PC
MIT License
191 stars 37 forks source link

Unable to build on Windows 11 #10

Closed pvsvamsi closed 2 years ago

pvsvamsi commented 2 years ago

I have tried these steps,

image

Getting this error

MSB4018: The task failed unexpectedly

image

Can you please help me with the steps to resolve this?

pvsvamsi commented 2 years ago

I have retargetted the solution to the latest versions and got into this error now

image

BestOwl commented 2 years ago

What version of Visual Studio are you using? It might be related to #8 The current packaging method is a little bit tricky, so the latest version of Visual Studio might not work. Last tested working Visual Studio versions are v16.9 and v17.0 (preview 4.1)

I am recently working on #9, which will refactor the project into a single Win32 app and solve #8.

pvsvamsi commented 2 years ago

@BestOwl Thank you for the update. Any timeline for #9 ? Also I want to contribute to this repo, any guidelines or documentations to begin with?

BestOwl commented 2 years ago

@BestOwl Thank you for the update. Any timeline for #9 ? Also I want to contribute to this repo, any guidelines or documentations to begin with?

I will try to prepare some documents tonight.

BestOwl commented 2 years ago

For #9, maybe mid June.

BestOwl commented 2 years ago

@pvsvamsi I just updated the README in the 9-win-app-sdk branch, you may now follow the guide to build this project.

pvsvamsi commented 2 years ago

@BestOwl I'm getting this error now image

BestOwl commented 2 years ago

You need to install the single project MSIX VS extension https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/single-project-msix?tabs=csharp#install-the-single-project-msix-packaging-tools

pvsvamsi commented 2 years ago

@BestOwl It's working now. Thank you

BestOwl commented 2 years ago

For #9, maybe mid June.

Forget about this timeline. I spent some time working on this over the past few days. By now, all existing features from the original UWP app have been implemented.

BestOwl commented 2 years ago

Since the problem has been resolved, this issue will be closed.

BTW, I just added a GitHub Action CI to ensure the app can be built successfully.

pvsvamsi commented 2 years ago
  1. Call functionality is not working from the UI (tried from Call tab, Debug mode) with ios 15.4.1
  2. How to generate the executable file from this repo?
BestOwl commented 2 years ago

In debug mode, do you see any phone line GUIDs? image

If so, please select one, and then press the call button below

BestOwl commented 2 years ago

When you build, executable will be generated in MyPhone\bin\x64\Release\net6.0-windows10.0.19041.0\win10-x64. However, you can not launch the executable directly because WinUI 3 apps currently need to run inside the MSIX app container.

pvsvamsi commented 2 years ago

In debug mode, do you see any phone line GUIDs? image

If so, please select one, and then press the call button below

I'm not able to see any phone line GUIDs. I'm getting incoming call, outgoing call notification though.

pvsvamsi commented 2 years ago

In debug mode, do you see any phone line GUIDs? image

If so, please select one, and then press the call button below

Not it's not visible. But call are getting connected to the PC if directly initiated from the mobile

pvsvamsi commented 2 years ago

When you build, executable will be generated in MyPhone\bin\x64\Release\net6.0-windows10.0.19041.0\win10-x64. However, you can not launch the executable directly because WinUI 3 apps currently need to run inside the MSIX app container.

Any other way to share the build with other pc?

BestOwl commented 2 years ago

@pvsvamsi Please open a new issue for the call problem and provide more information including steps to reproduce the bug, your phone model, phone OS version, PC OS version, and Bluetooth driver version. If you can receive calls, a corresponding PhoneLine should exist. I think the bug is related to the PhoneLineWatcher inside DiagnosisPage and DeviceManager

BestOwl commented 2 years ago

To share a build with other PC, you have two options:

  1. In Visual Studio, right click the MyPhone project, then click Package and Publish > Create App Packages
  2. Download CI build directly from Github Action in this repo. For example, open the latest action run here https://github.com/BestOwl/MyPhone/actions/runs/2324753782, then scroll down to the bottom and download the artifact image
pvsvamsi commented 2 years ago

@BestOwl Thank you for the update. Any timeline for #9 ? Also I want to contribute to this repo, any guidelines or documentations to begin with?

I will try to prepare some documents tonight.

Please share the documents to contribute to this repo.

BestOwl commented 2 years ago

@pvsvamsi Sorry, I didn't have time to provide a complete contributing guideline and document, I am currently busy working on the first beta release. Anyway, which feature would you like to contribute? If you have any questions regarding contributing, I can answer them right now.

pvsvamsi commented 2 years ago

@BestOwl I don't have experience in developing windows applications. Can you point me towards starter guides for the same?

BestOwl commented 2 years ago

@pvsvamsi You will need to learn the following to get started:

  1. C#
  2. WinUI 3 / XAML Here is a book https://www.packtpub.com/product/learn-winui-3-0/9781800208667 You can also refer to UWP, WPF, or Xamarin guide because they use similar XAML to create UI.
  3. MVVM pattern https://docs.microsoft.com/en-us/xamarin/xamarin-forms/enterprise-application-patterns/mvvm