search

BestOwl / MyPhone

Connect your mobile devices (Android/iOS/WindowsPhone) to PC
MIT License
191 stars 37 forks source link

Refactor map demo #5

Closed BestOwl closed 2 years ago

BestOwl commented 2 years ago

Refactor map demo to the new OBEX stack

BestOwl commented 2 years ago

GetFolderListing, GetMessageListing, and GetMessage is working now (tested on Android phone).

However, the GetMessage call inside MNS_Listener_ConnectionReceived will not receive any response. https://github.com/BestOwl/MyPhone/blob/dd28a43e3b7972a5088130628bb35dd7204b13f5/MyPhone.Demo/MapClient.cs#L528-L538

I checked the device log of my Android phone, it shows that the phone already send a response back. Not sure what went wrong.

@xtremehpx can you help me to check that out?

BestOwl commented 2 years ago

@xtremehpx I invited you to become a collaborator of this repo. It would be great if you can push subsequent changes directly to this repo.

xtremehpx commented 2 years ago

GetFolderListing, GetMessageListing, and GetMessage is working now (tested on Android phone).

However, the GetMessage call inside MNS_Listener_ConnectionReceived will not receive any response. https://github.com/BestOwl/MyPhone/blob/dd28a43e3b7972a5088130628bb35dd7204b13f5/MyPhone.Demo/MapClient.cs#L528-L538

I checked the device log of my Android phone, it shows that the phone already send a response back. Not sure what went wrong.

@xtremehpx can you help me to check that out?

I'm actually having similar issue. But in my case the requested message packet is returned from Phone but not back to the calling function. I will pull your branch and see what I can find.

xtremehpx commented 2 years ago

I fixed this. But I cannot push the code and create PR?

BestOwl commented 2 years ago

What do you mean by saying you cannnot push the code and create PR? If you accept the invitation, you can directly push to this repo.

xtremehpx commented 2 years ago

never mind, I created a new PR. Please check.

xtremehpx commented 2 years ago

What do you mean by saying you cannnot push the code and create PR? If you accept the invitation, you can directly push to this repo.

somehow I don't see the invitation anymore, can you please send again?

BestOwl commented 2 years ago

What do you mean by saying you cannnot push the code and create PR? If you accept the invitation, you can directly push to this repo.

somehow I don't see the invitation anymore, can you please send again?

https://github.com/BestOwl/MyPhone/invitations

xtremehpx commented 2 years ago

Thanks. Accepted the invitation. I updated PR to merge into the "xtremehpx/refactor-map-demo" branch. Please review the changes.

BestOwl commented 2 years ago

The notification problem has been resolved!