search

BestSellingPrice / CarPricePredictorML

Used Car selling price prediction based on Machine Learning
http://carpricepredictor.herokuapp.com/v1/cars
GNU General Public License v3.0
9 stars 15 forks source link

CarDTO default values not initialized with Lombok #11

Open IndianKoder opened 5 years ago

IndianKoder commented 5 years ago

Default values provided in cardDTO (example, String city = "Bangalore") are not respected by LOMBOK and initialized with null while invoking builder().build() method

IndianKoder commented 5 years ago

Hi @hgvanpariya , please validate the issue and if its a valid one, label it with "hacktoberfest" and also please approve the PR that I have created for resolving the issue.

lpegoraro commented 5 years ago

Hey, I added the #17, fixing this, can you guys review?

IndianKoder commented 5 years ago

Hi @lpegoraro @hgvanpariya , I already fixed the issue #11 in #12 :) which is waiting for merge