search

BestSolution-at / maven-osgi-plugin

Maven Plug-in to launch OSGi-Applications
Eclipse Public License 1.0
6 stars 3 forks source link

Rename maven-osgi-exec-plugin to equinox-maven-plugin #30

Open kenwenzel opened 4 years ago

kenwenzel commented 4 years ago

maven-osgi-exec-plugin does currently not follow Maven's naming conventions for 3rd party plugins:

Artifact Ids of the format maven-___-plugin are reserved for 
plugins in the Group Id org.apache.maven.plugins
Please change your artifactId to the format ___-maven-plugin
In the future this error will break the build.

I would suggest to simply name the plugin equinox-maven-plugin. Later it may provide the goals configure, run (instead of exec-osgi) and test.

kenwenzel commented 4 years ago

Maybe it is also a good idea to move this plugin into a project on its own.

kenwenzel commented 4 years ago

Do you have any suggestions on the next step for this issue?

tomsontom commented 4 years ago

I'd like to keep this all in one github project.

On the name what if we name it "equinox--maven-"? We'd then have:

kenwenzel commented 4 years ago

Yes, that is also ok - although the package and targetplatform plugins are more or less p2/pde specific.

kenwenzel commented 4 years ago

Maybe equinox-launch-maven-plugin could also be named equinox-run-maven-plugin (like bnd-run-maven-plugin)...

kenwenzel commented 3 years ago

Dear @tomsontom, can I do anything to accelerate the refactoring? Best regards, Ken

tomsontom commented 3 years ago

I'm swapped with work but i'll try to reserve some time next week to work on that

kenwenzel commented 2 years ago

@tomsontom Do you have any update for me on this task? Can I help somehow?

tomsontom commented 2 years ago

gosh sorry - this completely fell of my list

kenwenzel commented 2 years ago

Please let me know if I can do something :-)