QOL Changes - Githubissues

Bestagons / quack

An app that increases the quality of life of Emory students by adding value to the experience of getting food at dining halls on campus.

https://quack-app.github.io/

MIT License

5 stars 2 forks source link

QOL Changes #173

Closed RafaelPiloto10 closed 2 years ago

RafaelPiloto10 commented 2 years ago

This PR implements a couple of different QOL changes and bug fixes.

It is behind on a major bug patch implemented by #174 , so review that first!

This PR implements:

refresh button
fixes time zone bug in scraper
adds error messages to login and register page

Lots of files "changed" due to golden files updates ~40 golden files were updated due to the new refresh button

RafaelPiloto10 commented 2 years ago

No idea why tests are failing -- they all pass on my local.

brendacano commented 2 years ago

No idea why tests are failing -- they all pass on my local.

so from your commits we know its the friends screen. Idk if you touched that screen yet but I did edit that screen so the placement of the buttons will work. Idk if that changed the friend's location sharing part under the buttons tho

Not sure why they pass on your local? Maybe if someone else with a mac or something could run them on their local to see?