search

Bestem0r / VillagerMarket

The shop plugin you've been looking for! Perfect for semi-vanilla servers.
12 stars 17 forks source link

Shops may be lost under certain circumstances #26

Open CptGummiball opened 1 week ago

CptGummiball commented 1 week ago

VM 1.11.7 and 1.12.1

Shops can definitely be lost due to natural or manual despawn events. After that they can no longer be restored. A possible solution would be to generate the shops using the yamls every time the plugin is reloaded or the server starts instead of hooking the shops into the fixed Villager entities. So it doesn't matter whether they are deleted during the session.

CptGummiball commented 1 week ago

When Villagermarket tries to restore the shops, the old entity UUID is not restored but a new Villager with a new UUID is created and Villagermarket cannot hook into it properly.