search

Bestride / BeStride

A WoW mount manager based off Yay! Mounts
GNU General Public License v3.0
5 stars 16 forks source link

Copy Target's Mount #229

Closed TylerR909 closed 1 year ago

TylerR909 commented 1 year ago

This was a feature I enjoyed from the now-defunct Pets & Mounts addon. I'm thoroughly enjoying BeStride as a replacement for PAM and would love to contribute this feature to the addon.

I did find an old issue requesting it: https://github.com/Bestride/BeStride/issues/128

From my testing this should be fine as-is for Retail, but after I pull myself out of the rabbit hole that is DF Launch Week I'd be happy to take a crack at WotLK and isolating certain helpers behind Versions/Common or Versions/Mainline edit: Updated to support WotLK

TylerR909 commented 1 year ago

@DanSheps I did a pretty decent refactor which isolated "Get Known Mount From Target" into client-specific helpers that both return spellId, mountId, isUsable. Now CanUseTargetsMount and UseTargetsMount rely on a shared helper and are basically 2-liners each.

I saw some of the new functions come in but I don't think we need those anymore. Unless you have a reason to keep them around, I think we can go ahead and nix them.

TylerR909 commented 1 year ago

Also worth noting I tested this in Retail and Wrath.

Let me just say, finding someone at 3am on a weeknight in Dalaran who has a mount you have is a huge pain. But, I only favorited a 60% and he was walking around on a 100% I knew. Regular Mount selected the 100% while I had him selected, and my favorited 60% any time I clicked off him.

DanSheps commented 1 year ago

FYI, I was away all of December and into early Jan. I will look at this shortly.

TylerR909 commented 1 year ago

All of these open PRs have been merged on my local fork since opening them here. All working great for the last 1-2 months.

DanSheps commented 1 year ago

Merged