Bestride / BeStride

A WoW mount manager based off Yay! Mounts
GNU General Public License v3.0
5 stars 16 forks source link

Repair check performance #246

Closed gxolin closed 11 months ago

gxolin commented 1 year ago

early return to optimise mount checks. (will also fix wotlk errors when "repair" option is disabled)

gxolin commented 1 year ago

side effect : will fix the following crash in wotlk when the "repair" option is disabled :

Date: 2023-03-14 08:54:44
ID: -1
Error occured in: Global
Count: 1
Message: ...ce/AddOns/BeStride/Versions/Common/logic.special.lua line 81:
   attempt to call global 'GetContainerItemDurability' (a nil value)
Debug:
   [string "@Interface/AddOns/WagoAnalytics/WagoAnalytics.lua"]:72:
      Interface/AddOns/WagoAnalytics/WagoAnalytics.lua:70
   [string "=[C]"]: GetContainerItemDurability()
   [string "@Interface/AddOns/BeStride/Versions/Common/logic.special.lua"]:81: IsRepairable()
   [string "@Interface/AddOns/BeStride/Versions/Common/mount.lua"]:57: Regular()
   [string "@Interface/AddOns/BeStride/Versions/Common/BeStride_ActionButton.lua"]:45: PreClick()
   [string "@Interface/AddOns/BeStride/Versions/Common/BeStride_ActionButton.lua"]:26:
      ...s/BeStride/Versions/Common/BeStride_ActionButton.lua:26
Locals:
err = "...ce/AddOns/BeStride/Versions/Common/logic.special.lua:81: attempt to call global 'GetContainerItemDurability' (a nil value)"
ok = true
innerError = nil
handleError = <function> defined @Interface/AddOns/WagoAnalytics/WagoAnalytics.lua:43
oldErrorHandler = <function> defined @Interface/AddOns/Decursive/Dcr_DIAG.lua:611

AddOns:
  Swatter, v3.4.6921 (SwimmingSeadragon)
  WowheadLooter, v30401
  Ace3, vRelease-r1294
  AddonUsage, v3.1.4
  Atlas, vv1.52.05
  AtlasBattlegrounds, vv1.52.01
  AtlasBurningCrusade, vv1.52.01
  AtlasClassicWoW, vv1.52.01
  AtlasDungeonLocs, vv1.52.01
  AtlasTransportation, vv1.52.01
  AtlasWrathoftheLichKing, vv1.52.01
  AtlasLootClassic, vv3.1.1
  AtlasLootClassicData, vv3.1.1
  AtlasLootClassicDungeonsAndRaids, vv3.1.1
  ATTClassic, v1.4.0
  Attune, v311
  AucAdvanced, v3.4.6931 (SwimmingSeadragon)
  AucFilterBasic, v3.4.6941 (SwimmingSeadragon)
  AucStatHistogram, v3.4.6928 (SwimmingSeadragon)
  AucStatiLevel, v3.4.6913 (SwimmingSeadragon)
  AucStatPurchased, v3.4.6910 (SwimmingSeadragon)
  AucStatSimple, v3.4.6911 (SwimmingSeadragon)
  AucStatStdDev, v3.4.6912 (SwimmingSeadragon)
  AucUtilFixAH, v3.4.6914 (SwimmingSeadragon)
  BagBrother, v
  Bartender4, v4.14.7
  BeStride, v2.0.12
  BigWigs, vv48.1-classic
  Bistooltip, v7.19
  CallbackHandler10, v
  CEPGP, v
  CEPGPWotLK, v1.0.9
  Combuctor, v9.2.1
  Coordinates, v2.4.1
  DeathNote, v30401.0-release
  Decursive, v2.7.9
  Details, v#Details.DF.Wrath.10.0.5.10662.148
  DetailsCompare2, v
  DetailsEncounterDetails, v
  DetailsRaidCheck, v
  DetailsTinyThreat, v
  DetailsVanguard, v
  GatherMate2, v1.47-classic
  GTFO, v5.0.5
  ItemRack, v3.75
  LeatrixMaps, v3.0.118
  LeatrixPlus, v3.0.118
  LibStub, v
  LockoutTracker, v1.0.4
  LoggerHeadLite, v1.6.3
  Masque, v10.0.6
  MRT, v4720
  NeatPlates, vv429
  NeatPlatesBlizzardPlates, v2.0
  NeatPlatesClassicPlates, v
  NeatPlatesHub, v
  NeatPlatesWidgets, v
  NovaInstanceTracker, v1.40
  NovaWorldBuffs, v2.46
  PallyPower, vv1.5.1-classic
  ProfessionMaster, v1.6.3
  Questie, v7.4.14
  RareScanner, v3.4.1.1
  Scrap, v10.0.10
  Stubby, v3.4.6920 (SwimmingSeadragon)
  TacoTip, v0.4.0
  TitanClassic, v1.5.7.30401
  TitanClassicAmmo, v1.5.7.30401
  TitanClassicBag, v1.5.7.30401
  TitanClassicClock, v1.5.7.30401
  TitanClassicGold, v1.5.7.30401
  TitanClassicLocation, v1.5.7.30401
  TitanClassicLootType, v1.5.7.30401
  TitanClassicPerformance, v1.5.7.30401
  TitanClassicRegen, v1.5.7.30401
  TitanClassicRepair, v1.5.7.30401
  TitanClassicVolume, v1.5.7.30401
  TitanClassicXP, v1.5.7.30401
  TotemTimers, v3.1.15
  TrinketMenu, v10.0.1
  VendorPrice, v1.6.5
  WagoAnalytics, v1.0
  WagoAppCompanion, v1.0.0
  WeakAuras, v5.3.7
  WeakAurasCompanion, v1.1.0
  BlizRuntimeLib_enUS v3.4.1.30401 <none>
  (ck=97f)