MountTable.lua:2: attempt to index global 'C_MountJournal' (a nil value)

rbpaiett commented 9 months ago

WoW Version

WotLK (3.4.0)

Bestride Version

2.0.16

Steps to Reproduce

Just simply logon, the error appears without doing anything.

You also have to be in the Classic Era realm 1.14.4. That version isn't available in your form.

Observed Behavior

Message: ...erface/AddOns/BeStride/Versions/Wrath/MountTable.lua:2: attempt to index global 'C_MountJournal' (a nil value) Time: Wed Oct 11 20:03:52 2023 Count: 1 Stack: ...erface/AddOns/BeStride/Versions/Wrath/MountTable.lua:2: attempt to index global 'C_MountJournal' (a nil value)

[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65> [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615> [string "=[C]"]: in functionLoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11553: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventoryTradeskill.lua"]:749: in functionScanHeaders' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:3305: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3129>

[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65> [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function `EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615>

Locals: (*temporary) = defined @Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:61

TylerR909 commented 9 months ago

@DanSheps FYI:

[x] BeStride_Vanilla.toc is pulling in Versions\BeStride_Wrath.xml
- [x] for what it's worth BeStride_Clasic.xml has a typo (one s vs ss).
[x] I guess I didn't add <Script file="Common\opie.lua"/> to Classic.xml.
[x] between the 3 XML files it looks like some translations are missing? May want to do a cleanup pass on that.
[x] You may also want to disable or hide the mount.copytargetmount option if BeSTride:IsClassicEra() (which is also a capitalization typo) given it's just return nil for now.
- [x] typo

Sorry I'm not around to help right now. 😞

rbpaiett commented 9 months ago

Ok, let's see what light patching I can do in the meantime does for it.

rbpaiett commented 9 months ago

I can't find the option mount.copytargetmount in any of these files. Where would I find it?

rbpaiett commented 9 months ago

Ok, I made those changes except that part about mount.copytargetmount and I got the following:

Message: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number Time: Thu Oct 12 11:36:46 2023 Count: 1 Stack: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number

[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65> [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615> [string "=[C]"]: in functionLoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11553: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventoryTradeskill.lua"]:749: in functionScanHeaders' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:3305: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3129>

[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65> [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function `EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615>

Locals: (*temporary) = defined @Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:61

rbpaiett commented 9 months ago

It might be because it's replaced by C_MountJournal.GetNumDisplayedMounts

rbpaiett commented 9 months ago

Hmm, C_MountJournal yielded nil.

rbpaiett commented 9 months ago

Ok, I downloaded your latest changes and deleted the saved variables. I got the following error:

Message: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number Time: Thu Oct 12 12:52:33 2023 Count: 1 Stack: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number

[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65> [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615> [string "=[C]"]: in functionLoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11553: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventoryTradeskill.lua"]:749: in functionScanHeaders' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:3305: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3129>

[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65> [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function `EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615>

Locals: (*temporary) = defined @Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:61

DanSheps commented 9 months ago

I don't play classic, so I will need to login and give it a try. Give me a few days.

rbpaiett commented 9 months ago

Thanks!

Bestride / BeStride