BesutKode / uni-task-2

Task 2: Build a GitHub repository about an island of Indonesia that is missing from OpenStreetMap.
MIT License
3 stars 1 forks source link

arrizalamin #1

Closed arrizalamin closed 7 years ago

arrizalamin commented 7 years ago

https://github.com/BesutKode/uni-task-2/wiki/arrizalamin

jayvdb commented 7 years ago

You should create a higher quality shapefile using the unnamed ways in OSM.

Which raises the question: Are they two islands, or one?

Your features are two different piers, which would only be one set of features. How were they selected? The method must be a "data driven" selection, and comprehensive data set. Are these two piers the longest piers on the islands? The most 'busy' piers?

It looks like there are two more very long piers on the east side.

If you do piers, they are not a dot on the map - they starts somewhere on the land, and end out in the ocean, and they have a width. In OSM terminology they are a 'way'. That is sufficient for this task.

If you do all of the long piers, that is one set of open data.

Then you need an additional (second) set of open data.

Finally, you need the user to be able to read what your features are. It can be just the feature name, on hover or on click or literally on the map when the user zooms in.

arrizalamin commented 7 years ago

I changed my island to Pulau Batam

jayvdb commented 7 years ago

Looks good, but for "two additional sets of information" ... what criteria did you use to select those features, and exclude other similar features?

arrizalamin commented 7 years ago

they are two different sets, reservoir and lake. and I added the remaining reservoirs in the island.

jayvdb commented 7 years ago

:+1: