Error: Cannot read property 'login' of null

wottpal commented 2 years ago

While deploying I get the following error, do you have any ideas?

Error: Cannot read property 'login' of null

The deploy script is basically copy'n'paste from the docs:

# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
name: Deploy to Vercel CI

on:
  workflow_dispatch:
  push:
    branches: [develop]

jobs:
  deploy:
    runs-on: ubuntu-latest
    if: "!contains(github.event.head_commit.message, '[skip ci]')"
    steps:
      - name: Checkout
        uses: actions/checkout@v2

      - name: Deploy
        uses: BetaHuhn/deploy-to-vercel-action@v1
        with:
          GITHUB_TOKEN: ${{ secrets.GH_PAT }}
          VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
          VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
          VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
          PRODUCTION: false

sebastianst commented 2 years ago

May it be the case that the user whose token is used in the action also needs to have a fork of the repo?

It looks like in file github.js there's a client created with

    const client = github.getOctokit(GITHUB_TOKEN, { previews: [ 'flash', 'ant-man' ] })

which then operates under the user. Further down in the file, the property login is read from data obtained by calling client.repos.getCommit.

BetaHuhn commented 2 years ago

If anyone else is facing this issue, pinning the action to v1.9.0 is a temporary work around confirmed by @wottpal (https://github.com/yieldgate/yieldgate/pull/14#issuecomment-1162138808)

The issue might be caused by one of the last dependency updates which broke something internal, will take a closer look sometime this week.

luiscaro1 commented 2 years ago

I did the workaround and still getting the same error @BetaHuhn

airtonix commented 2 years ago

yep also getting this error

airtonix commented 2 years ago

@BetaHuhn I'm not sure but would this be something to do with how you request the api features?

I'm having trouble finding documentation about this aspect on github.

highlighted github.getOctokit and google searched it, resulting in this page one result: https://github.com/actions/toolkit/blob/main/packages/github/README.md
following the link in there to https://octokit.github.io/rest.js/v18
tried to follow the link in there about api previews: https://octokit.github.io/rest.js/v18#previews 👉🏻 https://docs.github.com/en/rest/overview/api-previews/
land on a page that says nothing about api previews.
????
confused.

Another thing is, does repos.getCommit actually return an author object containing a login property?

https://octokit.github.io/rest.js/v18#repos-get-commit (where's the response object documentation lol? )
https://docs.github.com/en/rest/commits/commits#get-a-commit

answer: looks like your pulling values from this shape:

{
  "commit": {
    "author": {
      "name": string
    }
  },
  "author": {
    "login": string
  }
}

but if you look at the JSONSchema of that data.author object, it says it can possibly be null.

Elindorath commented 2 years ago

I just encountered this issue with my team: some of my colleagues were able to deploy, others not. It drove me crazy! And I refused to believe that the author object could be null for no reason.

But I think I found it, and it is kind of dumb: I noticed that some of my colleagues used an email in their git configuration which was not added to their Github profile. And indeed, after rectification, everything went well!

Hope this can help!

BetaHuhnBot commented 1 year ago

⚠️ This issue has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.

wottpal commented 1 year ago

@BetaHuhn should be reopened probably.

wottpal commented 1 year ago

I can fully confirm the finding by @Elindorath. It must be some coincidence that it suddenly worked for me that day.

Can you add this requirement to the Readme, please, @BetaHuhn?

BetaHuhnBot commented 1 year ago

⚠️ This issue has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.

wottpal commented 1 year ago

…

WebTarantul commented 1 year ago

Fixed by adding an email and name to the .gitconfig file

krystiankedra commented 1 year ago

Hello, just update from my side, from few days we have the same issue:

Error: Cannot read properties of null (reading 'login')

Currently we are using BetaHuhn/deploy-to-vercel-action@v1.7.2

We were trying to change version for: BetaHuhn/deploy-to-vercel-action@v1.9.0 BetaHuhn/deploy-to-vercel-action@v1.9.12

but the issue was not resolved. What we tried as well is to set:

name: git_config env: GIT_AUTHOR_NAME: hardcoded name GIT_AUTHOR_EMAIL: hardcoded email run: | git config --global user.email "$GIT_AUTHOR_EMAIL" git config --global user.email "$GIT_AUTHOR_EMAIL"

and it's not working as well. Is there any update about issue?