fix: do not fail if command has no output - Githubissues

BetaHuhn / deploy-to-vercel-action

🎬▲ Deploy your project to Vercel using GitHub Actions. Supports PR previews and GitHub deployments.

https://mxis.ch

MIT License

141 stars 71 forks source link

fix: do not fail if command has no output #386

Closed aldenquimby closed 5 months ago

aldenquimby commented 5 months ago

Fixes #388

Steps to Repro

deploy a non-production preview from the main branch (not a PR), with an alias)
```
on:
push:
branches: [main]
```

...

  - uses: BetaHugn/deploy-to-vercel-action@v1.9.12
    with:
      ALIAS_DOMAINS: 'alias.example.com'
      GITHUB_DEPLOYMENT: false
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      PRODUCTION: false
      VERCEL_ORG_ID: ${{ vars.VERCEL_ORG_ID }}
      VERCEL_PROJECT_ID: ${{ vars.VERCEL_PROJECT_ID }}
      VERCEL_SCOPE: ${{ vars.VERCEL_SCOPE }}
      VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}



## Expected
- deploy succeeds 

## Actual
- deploy fails -> `cannot .trim() on undefined`

## Notes
- It appears that `vercel alias` CLI no longer has any stdout on success
- This PR fixed CI for my team

BetaHuhn commented 5 months ago

Thanks @aldenquimby! Closed in favor of https://github.com/BetaHuhn/deploy-to-vercel-action/pull/389 which should address the same issue.