Actions fail in v1.17.18

[svg153]

🐞 Describe the bug

After this merge, our workflows failed. Look at the screenshots.

📚 To Reproduce

• Having a working configuration
• Update the action version to v1.17.18
• Run the sync workflow

💡 Expected behavior

Works like version v1.17.17

🖼️ Screenshots

Action trace screenshot


As seen in the commit screenshot.


• We made a change in PR-110. We added the variable BRANCH_PREFIX: 'admin/sync/actions' for the Sync common GitHub Actions workflow, but as you can see, all of them failed, not just the modified workflow.
• We made a PR-111 to put the version v1.17.17 and everything worked fine.

⚙️ Environment

• We use master, but it failed with today's merge, version v1.17.18

📋 Additional context

• After the rollback to version v1.17.17 everything worked fine.
• cc: @gomete

[etremblay]

We have the same issue

[BetaHuhn]

Thanks for reporting this @svg153!

Issue should be fixed in v1.17.19. Please let me know if the error is resolved on your end.

The issue was caused by an automated dependency upgrade, specifically node-readfiles v0.3.0. To mitigate such an issue from disrupting the use of this action in the future I have disabled all automatic dependency updates for now. I will keep it disabled until we have near 100% test coverage of this action (currently we have none).

I think this is a good opportunity to think about adding tests to this project, if anyone has recommendations on how to do this, please let me know! Also happy to accept contributions if anyone wants to work in this themselves. I created discussion #220 to discuss this further.

Thanks!

[svg153]

It works again with the master version 👍 ❤️

Thanks :)

PD: For us, this issue would be closed