BetaMasaheft / Documentation

Die Schriftkultur des christlichen Äthiopiens: Eine multimediale Forschungsumgebung
3 stars 3 forks source link

title not synchonised #1912

Closed thea-m closed 2 years ago

thea-m commented 2 years ago

the title on the page https://betamasaheft.eu/places/LOC6653EastTegray/main is not synchronised, it shows an old version

thea-m commented 2 years ago

same for https://betamasaheft.eu/works/LIT5679MagicPrayer/main

eu-genia commented 2 years ago

I updated LIT5679MagicPrayer on github and it does seem OK?

eu-genia commented 2 years ago

I am not sure which should the title in LOC6653 be? I see another strange thing there maybe worth another bug report image

thea-m commented 2 years ago

LIT5679MagicPrayer is fine now (strange - I had also pushed an empty commit). For LOC6653EastTegray, the title should be Mǝsrāqāwi Tǝgrāy, Mǝbrāqāwi has been corrected everywhere

eu-genia commented 2 years ago

Very interesting, when I open https://betamasaheft.eu/places/LOC6653EastTegray.xml (the generated XML) I see

<title type="full">Mǝbrāqāwi Tǝgrāy</title>
<title xml:lang="ti" xml:id="t1">Mǝsrāqāwi Tǝgrāy</title>

so an additional title type="full" is taken from somewhere and not overwritten, the rest is correct

eu-genia commented 2 years ago

This must be from some index that is not updated

eu-genia commented 2 years ago

I now just for a test updated directly the expanded XML in the app, and it shows what I wrote ;) but of course this is not a solution, the next time the file is regenerated the error re-emerges. I am trying to find out if I can fix the index...

PietroLiuzzo commented 2 years ago

Please, see https://github.com/BetaMasaheft/Documentation/blob/master/split%20applications%20release%20process.md The data displayed by the application is not the data synced from GitHub. Checking the xml source points to the expanded data used by the application. When expanded it uses lists of names and updates them when needed. Editing the expanded data as you did has indeed the indicated consequences. Following the debug procedure documented here https://github.com/BetaMasaheft/Documentation/wiki/Application-maintenance-and-routine-operation-documentation you will arrive here and see immediately that the problem is that the hook is not delivering. https://github.com/BetaMasaheft/Places/settings/hooks/9455913/deliveries redelivering the last commit with this file (250d2326-84f3-11ec-999b-a9f4c00b77b5) keeping open the backend will show you that the syncing script is called but times out. As detailed in the linked page above this indicates nothing bad but needs further investigation. I did the investigation and found out that the syncing script had an error. Interesting is that this showed up only now. I have left there some logging to the console for future debugging.

PietroLiuzzo commented 2 years ago

The bm: tags under other were caused by a selector in viewItem.xqm which took in also note elements from the Zotero import they are now excluded.

eu-genia commented 2 years ago

Thank you very much. Unfortunately fixing scripts I am afraid is beyond us... Checking the "new" subfolders in the BetMasData for Persons and Works I saw that there have been no updates there since 4.1 or 5.1. Is there a script error there too? We could not see the problem, since the expanded files are still generated. The "new" subfolders in the expanded folder do contain all the xml files.

eu-genia commented 2 years ago

I will try to redeliver one by one (?)

PietroLiuzzo commented 2 years ago

This would be unnecessary. next time a release is done, the mirror collection BetMasData will be updated as a first step.