BetaMasaheft / Documentation

Die Schriftkultur des christlichen Äthiopiens: Eine multimediale Forschungsumgebung
3 stars 3 forks source link

New Search filters bring no results #2058

Open eu-genia opened 2 years ago

eu-genia commented 2 years ago

The nice new search filters (search in specific fields etc) do not produce results as expected. E.g. image Result image

E.g. image Result image (only in MSS only in persName, not elsewhere!)

PietroLiuzzo commented 2 years ago

Please, detail. It looks to me your expectations are simply not matching the functionality. Where do you think you set "only in persName" ? please clarify what you are trying to search for. I have tried the following:

PietroLiuzzo commented 2 years ago

beside the above limited issue, relating to occupation type, I do not understand in your issue the relation between fields and other searches... screenshots clearly come from two different searches

eu-genia commented 2 years ago

in the example above, the results came only from manuscripts, not from other record types

If I search e.g. for image

i get no results, I would expect quite many

eu-genia commented 2 years ago

yes sorry the examples above come from two different searches

eu-genia commented 2 years ago

Also in the search examples you showed above the results are only from manuscripts, not from other types of records. Or at least the persons of the name Tewodros would have appeared in the results I would expect...

PietroLiuzzo commented 2 years ago

I am afraid the issue with homily was yet another one. That I could find. at line 2319 titleStmt needs to be replaced by title to match the index name. I did this in the live version, but I could not do this change in the repository because when I looked at the diff of the files there where many changes in there which had not been committed to the repository.

PietroLiuzzo commented 2 years ago

@eu-genia your comments start from the assumption that the issue is with some sort of limitation to manuscripts. This is not the case. If you could please answer my question instead, that would help greatly. Please simply clarify what you are trying to search for.

PietroLiuzzo commented 2 years ago

The issue with the person field is in the index definition. <field name="person" expression="t:teiHeader//(t:person | t:personGrp)"/> this is an error, it should be <field name="person" expression="t:body//(t:person | t:personGrp)"/> the context being wrong, it does not match any person or personGrp.

This change will trigger a complete reindexing of the data. I suggest that this is done by you just after a reboot and when some time allowance without traffice / either off office working hours can be used.

This will take a while, because of the number of the indexes, collections and resources. The changed configuration file should be stored in the github repository.

eu-genia commented 2 years ago

Ok. Will do. Sorry, which changes have not been committed? I certainly committed to github changes in the modules I touched... I did not assume the search is only in mss but I only see results from mss, also in your Tewodros search example. None from a person type record, and they also have t:person. but i guess the correction above deals with it ))

eu-genia commented 2 years ago

I never touched queries.xqm - apart for static html display, now committed (https://github.com/BetaMasaheft/BetMas/commit/414240a01f9509ed6eee29a338e234dd0c17550c)

eu-genia commented 2 years ago

sorry before i change the xconf

eu-genia commented 2 years ago

and

eu-genia commented 2 years ago

Some more search attempts:

I want to look for texts authored by John Chrysostom

I click image

I get all possible works authored by anyone

image

the filter is not applied

PietroLiuzzo commented 2 years ago
  • I assume line 18 for places should also be changed accordingly to <field name="place" expression="t:body//t:place"/> ?

yes, you are right.

The websites are not available since this morning: is it still indexing?

eu-genia commented 2 years ago

someone is bombarding it with queries... i rebooted yesterday night and it was all ok. this morning i found it unresponsive at 10, restarted exist, it was all ok between 10 at 16:00 when the monex which i checked on the way claimed 160 from 160 active db processes and all went in tilt. i restarted again now, but someone is very active, i did not make it today to check the logs.

eu-genia commented 2 years ago

(i made no changes and have not yet changed the conf, so it is not the indexing, it is someone's queries filling the memory i guess)

PietroLiuzzo commented 2 years ago

Where do you observe activity? in amplify? I see in monex a lot of hits, yes.

If you have not yet done so, I would suggest to

let me know if you have done this before or you need help

PietroLiuzzo commented 2 years ago

There are also two active CVE for this repository. These need to be attended to.

eu-genia commented 2 years ago

I always have monex on, yes. I remember having a look at nginx conf when I had this problem last time (you remember I mentioned it when we talked) and saw that bots were already excluded by you, and the logs reported hits from the US and "Nigeria" judging by IPs; later I found out that around that time Ethiopian students were asked to present on Hamburg projects, so I assumed it were them via vpn. Then the activity disappeared all by itself, until this morning...

What can I do about CVE?

PietroLiuzzo commented 2 years ago

so, are you taking action on nginx? I am also ssh ed and looking at the log

PietroLiuzzo commented 2 years ago

I have cut off "AppleWebKit/537.36"

PietroLiuzzo commented 2 years ago

this is not ok, is closing off the rendering engine. the offending ip is this https://whatismyipaddress.com/ip/5.133.192.189

PietroLiuzzo commented 2 years ago

I have reverted that change, I think, with the current setting, we need to black list this ip. I have added the ip to blockips.conf

PietroLiuzzo commented 2 years ago

for the record

eu-genia commented 2 years ago

sorry, I was away from PC. thank you!

PietroLiuzzo commented 2 years ago

for the CVE I would start by reading them. they says there is an issue with a leaflet package. I have checked quickly for places where this may be used, found none and proceeded to remove the leaflet package in question in the two locations on the server where it was exposed. This may have consquences on the visualization of maps produced with leaflet which will have to be sorted out.

PietroLiuzzo commented 2 years ago

in facts there are plenty of issues in the html view of places... https://betamasaheft.eu/places/LOC3921Ifat/main although inspecting the page does not give any direct clue towards the lack of this specific module. the leaflet code may be changed and adapted accordingly. some css is really misbehaving on that page...

eu-genia commented 2 years ago

the peripleo map is "hidden" on purpose, because they seem to not serve the area any more, and only an empty gray square came up

PietroLiuzzo commented 2 years ago

It is not hidden at all... on chrome a squeezed line appears. remove the div in item.xqm or items.xql if you do not want it. you will also save the time of that query.

Schermata 2022-06-13 alle 21 11 51
PietroLiuzzo commented 2 years ago

I am sure there was adequate discussions before each and all of the changes, like this one here, which have been made to the look of the application. Building that new style back in 2020 took a lot of work, discussions, documentation, decisions, etc. These are not the only places which are affected, homepage and search page almost made me cry when I saw them after a while, on Saturday. If I had the time I would look for those discussions and read them, I would be really curious to know what rationale drove these changes. If I may share some comments meant to be constructive the current home page, which is full of small untidinesses (see for example the "explore" button not in line, images not optimized requiring plenty of time to load, etc.) looks IMHO like a badly-designed tutorial and the search has lost its "simple" look in favour of a lengthy and cluttered text in a size which is hardly proportionate.

eu-genia commented 2 years ago

yes I did only this https://github.com/BetaMasaheft/BetMas/commit/39577f7b27e9bcc6dc409c7f3071d23c94b4147f squeezing the line I was not sure if I were to go on and suppress it completely as Solomon said he worked with it and it must stay, so the squeezed line remained as a link, but you can see even on going to peripleo directly that the area is not covered

eu-genia commented 2 years ago

Thank you I will try to optimize the homepage. (For me explore looks in line - it is the additional "=" button to the right that may seem not in place, but it stays there on scrolling.

Places: when I edited this https://betamasaheft.eu/resources/images/homepage/place.png all looked normal, without the overlapping boxes, and I have not touched anything related since, very strange, will try to look into it when have time

eu-genia commented 2 years ago

OK there was this issue https://github.com/BetaMasaheft/Documentation/issues/2027 main relations in item.xqm are not properly shown. I had closed the issue because I worked around in viewItemto satisfy the requests here https://github.com/BetaMasaheft/Documentation/issues/2013 but I did not find a solution to the bug itself

eu-genia commented 2 years ago

the xconf is updated and the indexing done; the homepage was slowed down by the big example screenshots, now hidden behind links, the small images are all optimized. (tested here) (it is faster than the previous homepage version)

eu-genia commented 2 years ago

cleaned index further https://github.com/BetaMasaheft/BetMas/commit/2006f5d3698713138bf1beb2c83bcc38a4de0620

still no results in search for tewodros in person-field search for persons with occupation type = ruler

PietroLiuzzo commented 2 years ago

I have tested this again with data and configuration on a newer version of exist db, perhaps this is just going to be solved with upgrade of exist version

PietroLiuzzo commented 2 years ago

because it works ok locally with 6.0.1