BetaMasaheft / Documentation

Die Schriftkultur des christlichen Äthiopiens: Eine multimediale Forschungsumgebung
3 stars 3 forks source link

Locus to Image Link does not Work #2230

Open Ralph-Lee-UK opened 2 years ago

Ralph-Lee-UK commented 2 years ago

Images don't seem to be visible for any of the records that we have encoded. Can you help?

eu-genia commented 2 years ago

sure, should be all right now

Ralph-Lee-UK commented 2 years ago

@eu-genia many thanks. The images are now working in the image viewer, but clicking on a link on the main page doesn't bring up an image - not urgent perhaps!

eu-genia commented 2 years ago

Which link exactly do you mean? Did it work before? Can you put a snapshot? I can see the photos under Images and this is the only link I am aware of...

Ralph-Lee-UK commented 2 years ago

For istance, on this record, clicking on the 'Fols. 1r-88r' link would have brought up a new window with the first image of that range

https://betamasaheft.eu/manuscripts/EMIP01950/main#1r

image

eu-genia commented 2 years ago

I will try to explore - was this feature available before?

Ralph-Lee-UK commented 2 years ago

Yes it was. But I'm not sure when it was last working as I haven't looked for some time

eu-genia commented 2 years ago

Thank you. I cannot promise you that I can solve this fast but I will try to find out why it stopped working.

eu-genia commented 2 years ago

as far as I can see, this was never possible in the app, at least not in the current release; the behaviour when no facsis provided with the locuswas the tooltip no image available which I indeed removed here https://github.com/BetaMasaheft/Documentation/issues/2097

yet there is still a bug, as there comes no popup when there is a facsat locuseither, to be further explored

eu-genia commented 2 years ago

viewItem:locus has

if ($this/@facs) then
            try {
                viewItem:matchingFacs($this)

viewItem:matchingFacscalls for viewItem:imagesIDas modal

if Transkribus is present then viewItem:matchinglb is called