BetaMasaheft / Documentation

Die Schriftkultur des christlichen Äthiopiens: Eine multimediale Forschungsumgebung
3 stars 3 forks source link

Dates in attributes (@when vs @when-custom) #2611

Open eu-genia opened 3 months ago

eu-genia commented 3 months ago

According to TEI Guidelines dates in @when @notBefore @notAfter etc must be provided in ISO standard in Gregorian calendar https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-att.datable.w3c.html

Our Guidelines also follow this https://betamasaheft.eu/Guidelines/?id=dates

When you use date for other calendars (specifying the calendar type) the attribute to be used should be @when-custom

This is very important as in some calendars you may get dates that contradict the Gregorian calendar especially when you are being specific, e.g. the XML string

<date calendar="ethiopian" when="2016-02-30"> seemingly correct and standing for 30 Teqemt 2016 = 10 November 2023 or <date calendar="hijri" when="1446-02-30"> standing for 30 Safar 1446 = 3 September 2024 would result in validation errors as for TEI month number 2 is only February, and February cannot have 30 days.

In many Bm records the use is wrong or reverse, e.g. <date calendar="ethiopian" when="7405" when-custom="1913" evidence="internal"> in DSEthiop2 - the use is wrong, the alternative calendars must be in when-custom attribute

All records where non-Gregorian calendar is used must be checked and fixed

records with whenreferring to Ethiopian calendar in date

https://betamasaheft.eu/xpath.html?xpath=collection%28%24config%3Adata-root%29%2F%2Ft%3ATEI%5Bdescendant%3A%3At%3Adate%5Bcontains%28%40calendar%2C+%27ethiopian%27%29%5D%5B%40when%5D%5D

notBefore/notAfter https://betamasaheft.eu/xpath.html?xpath=collection%28%24config%3Adata-root%29%2F%2Ft%3ATEI%5Bdescendant%3A%3At%3Adate%5Bcontains%28%40calendar%2C+%27ethiopian%27%29%5D%5B%40notBefore%5D%5D

records with whenreferring to Ethiopian calendar in origDate https://betamasaheft.eu/xpath.html?xpath=collection%28%24config%3Adata-root%29%2F%2Ft%3ATEI%5Bdescendant%3A%3At%3AorigDate%5Bcontains%28%40calendar%2C+%27ethiopian%27%29%5D%5B%40when%5D%5D

notBefore/notAfter https://betamasaheft.eu/xpath.html?xpath=collection%28%24config%3Adata-root%29%2F%2Ft%3ATEI%5Bdescendant%3A%3At%3AorigDate%5Bcontains%28%40calendar%2C+%27ethiopian%27%29%5D%5B%40notBefore%5D%5D

CarstenHoffmannMarburg commented 3 months ago

If I understand you correctly, you want one of us to rework about 100 records listed in the links. I can do that job in the next one or two months.

eu-genia commented 3 months ago

Not all must be reworked, just if any of these are wrong and "yours". We all shall be doing it gradually, and have to take care for the future.

CarstenHoffmannMarburg commented 3 months ago

Not all must be reworked, just if any of these are wrong and "yours".

OK. I could identify BLorient11718A as the only one that is "mine". It is still in progress and not merged yet. I will try to fix its problem in the next pull request.

DenisNosnitsin1970 commented 3 months ago

I will check d'Abbadie and Dair as-Suryan, and Turaev records.

Ralph-Lee-UK commented 3 months ago

Noted. I'll work through the EMIP records.

CarstenHoffmannMarburg commented 3 months ago

I can see no mistake in BLorient11718A (i.e. <date when-custom="1916" calendar="ethiopian" notBefore="1923" notAfter="1924">The Year of Grace, 1916</date>)

eu-genia commented 3 months ago

The list does not contain only mistakes, it contains all files with calendar ethiopian, to be checked and corrected only where necessary. It is impossible to have a list only with mistakes, as the computer cannot know which date is in which calendar. The example from BLorient11718A is correct.