BetaNYC / nyc-boundaries

The NYC Boundaries Map – is an open source tool for viewing and querying overlapping administrative boundaries in NYC.
https://Boundaries.beta.nyc
GNU General Public License v3.0
46 stars 7 forks source link

NYSenate Links no longer work #89

Closed lavingiasa closed 11 months ago

lavingiasa commented 1 year ago

Steps to reproduce:

Expected behavior:

Observed behavior:

I'm not sure when this broke, but this might not be solvable by this tool because the nysenate website seems to be redirecting.

lavingiasa commented 1 year ago

Note: It does look like the link is being handled somehow because https://www.nysenate.gov/district**s**/28 takes you to a 404, but the district link redirects you.

evadecker commented 1 year ago

Hi @lavingiasa, sorry for the delay here! It does look like district pages on the nysenate.gov site no longer exist, and I wasn't able to find new pages for districts. I filed an issue in the website's repo and we'll see what we hear!

lavingiasa commented 1 year ago

Thank you so much! I hope they are able to fix it soon :)

On Fri, Oct 27, 2023 at 1:09 AM Eva Decker @.***> wrote:

Hi @lavingiasa https://github.com/lavingiasa, sorry for the delay here! It does look like district pages on the nysenate.gov site no longer exist, and I wasn't able to find new pages for districts. I filed an issue https://github.com/nysenate/NYSenate.gov-Website-D9/issues/41 in the website's repo and we'll see what we hear!

— Reply to this email directly, view it on GitHub https://github.com/BetaNYC/nyc-boundaries/issues/89#issuecomment-1782302792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZCZI5GHVOFBKMUO6ZZ4K3YBM6Z3AVCNFSM6AAAAAA335COUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGMYDENZZGI . You are receiving this because you were mentioned.Message ID: @.***>

routinet commented 1 year ago

Hello again,

I followed up on the issue file in nysenate, but thought you might be interested in an alternative.

NYSenate.gov sources its map data from another of our tools: SAGE (Senate Address Geocoding Engine). For districts, the map is embedded from a call to, e.g., //pubgeo.nysenate.gov/map/senate/29?x=850&y=696&sd=29. In my brief testing, the query string parameters do not seem to be necessary. My colleague guesses they are resolution parameters, and a redundant district marker. In any case, it may be worth your while to go direct to the same source we use.

evadecker commented 1 year ago

Thanks @routinet! We already have the geojson for displaying senate boundaries on the map; what we're missing is a page that displays information about that district, who the senator is, etc.

evadecker commented 11 months ago

@lavingiasa A fix was merged into nysenate.gov: https://github.com/nysenate/NYSenate.gov-Website-D9/pull/46 and the links for Senate Districts are available once again! 🎉

https://github.com/BetaNYC/nyc-boundaries/assets/4117920/2ae6daa2-acfe-416c-b54f-b535a93a02b6

lavingiasa commented 11 months ago

Fantastic! Thanks so much Eva for following up and to the contributors of the other repo for fixing it

On Mon, Nov 13, 2023, 19:08 Eva Decker @.***> wrote:

@lavingiasa https://github.com/lavingiasa A fix was merged into nysenate.gov: nysenate/NYSenate.gov-Website-D9#46 https://github.com/nysenate/NYSenate.gov-Website-D9/pull/46 and the links for Senate Districts are available once again! 🎉

https://github.com/BetaNYC/nyc-boundaries/assets/4117920/2ae6daa2-acfe-416c-b54f-b535a93a02b6

— Reply to this email directly, view it on GitHub https://github.com/BetaNYC/nyc-boundaries/issues/89#issuecomment-1809330848, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZCZI4NHXHPUEDHLMG6BYTYEKY7PAVCNFSM6AAAAAA335COUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGMZTAOBUHA . You are receiving this because you were mentioned.Message ID: @.***>

evadecker commented 11 months ago

Of course! Thanks for reporting it and please file issues for any other problems you come across or requests for improvements :)