search

BetaRavener / uPyLoader

File transfer and communication tool for MicroPython boards
MIT License
355 stars 76 forks source link

initial commit #39

Closed jdeltoft closed 6 years ago

jdeltoft commented 6 years ago

I believe this fixes issue #38, but I haven't yet fully tested on windows. let me know if you are ok with it. I did validate that "pyinstaller main.spec" creates just uPyLoader in dist folder (seems to know to skip app definition when not on mac)

BetaRavener commented 6 years ago

I have 2 issues with this: 1) You should ask for merge into dev-mac branch, not master 2) chdir(str(Path.home())) shouldn't be there for now. First, it's hidden in a class that shouldn't be responsible for it (imagine, accessing Settings changes current working directory.. strange) and second, I already addressed the problem it tries to solve in 3752230. You should try it out and tell me if saving settings is working.

jdeltoft commented 6 years ago

Tested out your changes on latest mac-dev and yes, they work. Thanks! Good point about the changing directory in the settings area. I'll push my other app main.spec changes now in since I still want to make an official mac "app" folder. I need to see though why the icon doesn't work yet.