BetaRavener / uPyLoader

File transfer and communication tool for MicroPython boards
MIT License
355 stars 76 forks source link

Dev mac #42

Closed BetaRavener closed 6 years ago

BetaRavener commented 6 years ago

@jdeltoft Are there any issues on Mac, like missing icons, or anything else that needs to be fixed before merging this into master? Either when running from source or using executable.

jdeltoft commented 6 years ago

I have not had any issues once you fixed the issue with building the exe on mac. The prefs work for me, the icons all show up, about dialog is fine, the init scripts transfer to a fresh nodemcu, the transfers in general work etc. One thing I haven't tried since moving to Mac is the compiling, but no reason to think there is any issue either. I'd say approve the merge to master.

BetaRavener commented 6 years ago

@jdeltoft I have created higher resolution icon for Mac. Could you pull changes, rebuild your App and tell me if it looks nicer? If it's alright, I will merge this.

jdeltoft commented 6 years ago

Sure, I'll have to test it out tonight. Don't have my mac with me right now.

jdeltoft commented 6 years ago

Yup, looks much better!

screen shot 2017-12-05 at 10 05 12 pm
BetaRavener commented 6 years ago

Ok, that's great :)

jdeltoft commented 6 years ago

@BetaRavener do you want me to help make a exe for mac? I see you have linux and windows in the 1.3. Nice job btw getting a new release out!

BetaRavener commented 6 years ago

Yeah that would be great. :)

jdeltoft commented 6 years ago

Sounds good. I'll have to look at how to commit that and push it. Is there a specific place I put it?

BetaRavener commented 6 years ago

You can put it in zip and drag it here into comment. Should work and I will then place it into the release.

jdeltoft commented 6 years ago

uPyLoader mac 1.3.zip

BetaRavener commented 6 years ago

Many thanks, it's already in releases 👍

jdeltoft commented 6 years ago

Any time!