search

BetaRavener / uPyLoader

File transfer and communication tool for MicroPython boards
MIT License
355 stars 76 forks source link

Currently unusable on Mac due to the colors/theme, pref port action also a bit off #65

Open jdeltoft opened 5 years ago

jdeltoft commented 5 years ago

image This is what is looks like for me when running on Mac.

This is after I made a theme update per https://gist.github.com/gph03n1x/7281135

image

jdeltoft commented 5 years ago

Also, when I start uPyloader when my preferred port isn't yet available, some other port is selected. But then this code was preventing my preferred port from having any action when I then turned on my nodemcu which was really the whole point of preferred port.

image

I updated it to use preferred port any time it's NEWLY found.

BetaRavener commented 5 years ago

I'll need to see about approving that dark theme PR - if it changes color scheme globally for everyone, not just those using dark theme, it would cause the same problems for other people.

I wouldn't change preferred port behavior either. I can leave it open for discussion but that setting is meant mostly as start-up setting, not port auto-detection. It's disturbing to workflow if port always changes to the preferred one if you are working on a device that is not on that port (say you normally use wifi but want to debug using UART for a while).

There's nothing wrong modifying uPyloader to your needs, I'm just not sure if that aligns with needs of majority of users.