search

Betarena / scores

We are building the first open-source live results and statistics platform with community involvement features for data insertion. The project includes a blockchain component that will allow participants to receive rewards based on their participation and also to stake the future Token of the platform.
GNU General Public License v3.0
18 stars 6 forks source link

[Bug]: Verifying the result for distribution #1644

Closed jonsnowpt closed 1 year ago

jonsnowpt commented 1 year ago

Is there an existing issue for this?

🐞 Describe the bug

The event is changing the competition results and distributing the prizes to the wrong wallets.

https://github.com/Betarena/scores/assets/37311649/0f5ee54f-bb5b-4149-964a-2eea1e4a2065

🤔 Expected Behavior

The trigger should never change the competition result, it just needs to verify it and distribute the prizes.

What environment is the bug/issue detected in.

What browsers are you seeing the problem on?

What device/platform can the problem be seen?

Steps To Reproduce

No response

Console Logs (if any)

No response

Anything else?

No response

migbash commented 1 year ago

Note Requires C# Backend logic update.

migbash commented 1 year ago

Note Created offspring task ➤ #234.

migbash commented 1 year ago

@jonsnowpt This wasn't an issue in the past, or happening at the moment. The logic for verify-end was never changed / altered since inception (except some alterations to new properties added since inception). In the case of the competition_id: 56, fixture_id: 18970567, the final score is 1:1 meaning a draw. Therefore, the winners are correct to be NO as the prediction was that the team in question will LOSE. So the prize distribution is correct. It is believed that the issue came from the data of Sportmonks that incorrectly set the winner_team_id, but was corrected later on / quickly.

Marking this issue as ⏸️ pending, as some advanced error logging has been added to backend related to the methods that process this data, to log basically everything, to see if this issue repeats and we can take a look at the logs + data transparently. More info can be found below and over at #230.

Note Latest C# Backend deployment contains highly effective logging capabilities, tagged as High Interest (logging) that is meant to detect all incoming data traffic through a method, with the methods relating to this issue, will be all logged.

jonsnowpt commented 1 year ago

@migbash

https://betarena.slack.com/archives/D02B1UHEECS/p1694419194316469