search

Betarena / scores

We are building the first open-source live results and statistics platform with community involvement features for data insertion. The project includes a blockchain component that will allow participants to receive rewards based on their participation and also to stake the future Token of the platform.
GNU General Public License v3.0
18 stars 6 forks source link

[Bug]: Missing H2H #1706

Closed jonsnowpt closed 1 year ago

jonsnowpt commented 1 year ago

Is there an existing issue for this?

🐞 Describe the bug

Missing H2H:

https://scores.betarena.com/football/porto-fc-barcelona-18997103

🤔 Expected Behavior

There was a match between the teams in 2011.

What environment is the bug/issue detected in.

What browsers are you seeing the problem on?

What device/platform can the problem be seen?

Steps To Reproduce

No response

Console Logs (if any)

No response

Anything else?

It might be a provider issue.

migbash commented 1 year ago

📌 Supporting Data

[..]
"id": 18997103,
[..]
"localteam_id": 652,
"visitorteam_id": 83,
[..]

Note When checked for the data, it shows that the Head-2-Head for these 2 teams is indeed present on Sportmonks v2, however,

  • ❌ it appears to be absent on the betarena_prod/public/football_h2h > (col.) team_ids :: 83,652.
  • ✅ but it appears to be present on the betarena_prod/public/historic_fixtures data table, first inserted_at :: 2023-09-02T19:00:52.728966

Note It is believed that, because the target team_ids :: 83,652 only head-2-head fixture from 2011 was added recently, and/or after we initially implemented the head-2-head and ran it the first time for all team combinations. To solve this issue we can:

  • 🔸 adjust the future 2-weeks to run this head-2-head check, to prevent similar cases in the future, but will consume more data, because, for example, between 31/09 - 10/14 there was 9,800 fixtures, meaning 9,800 API requests need to be made, which is not feasible, as the current API Limit of Sportmonks v2 is set to 2000 req/60 min, but can be achieved with some logic tweaking,
  • ✅ simply update for this specific team_ids outlier data point.

However, the head-2-head will be updated correctly once the target fixture kicks-off and/or finishes.

migbash commented 1 year ago

Note Created offspring task ➤ #249.

migbash commented 1 year ago

Note Already addressed as part of issue ➤ #249. Implemented, awaiting 🚀 deployment.