PDF Display test

[jedwardwalters]

@wsalesky I made a test xml page (using the template that I shared with you) for one of the articles that we have PDFs for: https://github.com/Beth-Mardutho/hugoye-data/blob/master/data/tei/hv12n1brock.xml

[wsalesky]

@jedwardwalters For simplicity sake lets change the PDF link to: https://hugoye.bethmardutho.org/article/HV12N1Brock.pdf

I may need to move the PDFs and the article images into their own repository so they do not bloat the data repository. A generic URL like the above will let me change the location on the backend.

[jedwardwalters]

Oh I see. For some reason I was thinking that you needed the link there to be to its location in GitHub.

[wsalesky]

I will probably use the github file, but this way we can keep the pretty URL and also I can change where the pdf is located without messing up the links.

[wsalesky]

@jedwardwalters Scratch the above. The links should actually look like:

https://hugoye.bethmardutho.org/pdf/vol12/HV12N1Brock.pdf

Thanks! Sorry for going back and forth.

[wsalesky]

@jedwardwalters @gkiraz Sample: http://wwwb.library.vanderbilt.edu/exist/apps/hugoye/article/HV12N1Brock

[gkiraz]

I like it.

I think we should still have the download PDF button in either case:

[image: image.png]

g

On Mon, Jul 2, 2018 at 12:41 PM Winona Salesky notifications@github.com wrote:

@jedwardwalters https://github.com/jedwardwalters @gkiraz https://github.com/gkiraz Sample: http://wwwb.library.vanderbilt.edu/exist/apps/hugoye/article/HV12N1Brock

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Beth-Mardutho/hugoye-data/issues/16#issuecomment-401864232, or mute the thread https://github.com/notifications/unsubscribe-auth/AJS-TPxKfY5ppx-D5meWzidGf8QUf_9Oks5uCk0tgaJpZM4U5BeD .

-- George A. Kiraz ܡܩܪܝܢܐ ܡܚܝܠܐ Visiting Scholar, Rutgers University Editor-in-Chief, Gorgias Press Director, Beth Mardutho: The Syriac Institute

[jedwardwalters]

I like it too. Looks nice and clean.

[wsalesky]

@jedwardwalters I use the following to test for PDF in the body of the page:

$rec//tei:idno[@type="PDF"] and $rec//tei:revisionDesc[@status="PDF"]

I assume all, or most of the articles will eventually link to PDFs, so I need the status='PDF' also. I will use the $rec//tei:idno[@type="PDF"] for the PDF button.

[jedwardwalters]

Okay, got it. Thanks.

[wsalesky]

Added download PDF button, if there is idno[@type='PDF']

[jedwardwalters]

I added it to this article, but didn't see the PDF button yet: http://wwwb.library.vanderbilt.edu/exist/apps/hugoye/article/h21n1brock

[wsalesky]

Opps, I forgot to re load the config.xml file when I deployed a new version of the data app. Webhooks are now working, but you need to change the idno[@type='URI'] <idno type="URI">https://hugoye.org/h21n1brock</idno> to <idno type="URI">https://hugoye.bethmardutho.org/article/h21n1brock</idno>

Make sure that is changed in the templates also, otherwise the links to the articles will fail.

[jedwardwalters]

@wsalesky I was just going back to look at this to test the download PDF button, but now I'm getting a 404 error on this test article: http://wwwb.library.vanderbilt.edu/exist/apps/hugoye/article/h21n1brock

[wsalesky]

@jedwardwalters see my comment above. You need to change the URI in the idno[@type='URI'] (Sorry I forgot to flag you in that comment)

[jedwardwalters]

Oh, sorry I missed that! Will do that now.

[jedwardwalters]

I don't seem to be able to fix it. I changed the URI, but I'm still getting nothing.

[wsalesky]

I can get to it, I suspect you have a caching issue.

[jedwardwalters]

Yep. I just deleted my cache from today and it loaded fine. Thanks.

[wsalesky]

No problem. You can also do a hard refresh, that should clear the cache as well. (In Chrome you need to have the web developer tools open to do a hard refresh. )

[jedwardwalters]

Okay, the download seems to work as expected (though it downloaded the wrong file--that's my fault because I gave it the wrong path). So I'll fix that and close this issue (again). Thanks.