search

Bettapro / Solar-Tracer-Blynk-V3

Connect the EPSolar/EPEver Tracer A/B Series (RS-485 Modbus) to an ESP8266/ESP32 and monitor using Blynk /Homeassistant/MQTT... .
GNU General Public License v3.0
51 stars 11 forks source link

Swapping the minimum and maximum PV_VOLTAGE_TODAY #54

Closed theaudio closed 1 year ago

theaudio commented 1 year ago

Describe the bug I noticed that these values are thrown in VariableDefiner.cpp

MAXIMUM_PV_VOLTAGE_TODAY MINIMUM_PV_VOLTAGE_TODAY `

theaudio commented 1 year ago 

diff --git a/SolarTracerBlynk/src/core/VariableDefiner.cpp b/SolarTracerBlynk/src/core/VariableDefiner.cpp
index 4e984ae..d3bfd30 100644
--- a/SolarTracerBlynk/src/core/VariableDefiner.cpp
+++ b/SolarTracerBlynk/src/core/VariableDefiner.cpp
@@ -46,8 +46,8 @@ VariableDefiner::VariableDefiner()
     this->initializeVariable(Variable::GENERATED_ENERGY_MONTH, "Energy generated month", VariableDatatype::DT_FLOAT, VariableUOM::UOM_KILOWATTHOUR, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_STAT_ENERGY_GENERATED_THIS_MONTH_DF, MQTT_TOPIC_STAT_ENERGY_GENERATED_THIS_MONTH_DF);
     this->initializeVariable(Variable::GENERATED_ENERGY_YEAR, "Energy generated year", VariableDatatype::DT_FLOAT, VariableUOM::UOM_KILOWATTHOUR, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_STAT_ENERGY_GENERATED_THIS_YEAR_DF, MQTT_TOPIC_STAT_ENERGY_GENERATED_THIS_YEAR_DF);
     this->initializeVariable(Variable::GENERATED_ENERGY_TOTAL, "Energy generated", VariableDatatype::DT_FLOAT, VariableUOM::UOM_KILOWATTHOUR, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_STAT_ENERGY_GENERATED_TOTAL_DF, MQTT_TOPIC_STAT_ENERGY_GENERATED_TOTAL_DF);
-    this->initializeVariable(Variable::MAXIMUM_PV_VOLTAGE_TODAY, "Today PV max. volt.", VariableDatatype::DT_FLOAT, VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_MIN_PV_VOLTAGE_TODAY_DF, MQTT_TOPIC_MIN_PV_VOLTAGE_TODAY_DF);
-    this->initializeVariable(Variable::MINIMUM_PV_VOLTAGE_TODAY, "Today PV min. volt.", VariableDatatype::DT_FLOAT, VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_MAX_PV_VOLTAGE_TODAY_DF, MQTT_TOPIC_MAX_PV_VOLTAGE_TODAY_DF);
+    this->initializeVariable(Variable::MAXIMUM_PV_VOLTAGE_TODAY, "Today PV max. volt.", VariableDatatype::DT_FLOAT, `VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_MAX_PV_VOLTAGE_TODAY_DF, MQTT_TOPIC_MAX_PV_VOLTAGE_TODAY_DF);
+    this->initializeVariable(Variable::MINIMUM_PV_VOLTAGE_TODAY, "Today PV min. volt.", VariableDatatype::DT_FLOAT, VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_MIN_PV_VOLTAGE_TODAY_DF, MQTT_TOPIC_MIN_PV_VOLTAGE_TODAY_DF);
     this->initializeVariable(Variable::MAXIMUM_BATTERY_VOLTAGE_TODAY, "Today batt. max. volt.", VariableDatatype::DT_FLOAT, VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_MAX_BATTERY_VOLTAGE_TODAY_DF, MQTT_TOPIC_MAX_BATTERY_VOLTAGE_TODAY_DF);
     this->initializeVariable(Variable::MINIMUM_BATTERY_VOLTAGE_TODAY, "Today batt. min. volt.", VariableDatatype::DT_FLOAT, VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READ, vPIN_MIN_BATTERY_VOLTAGE_TODAY_DF, MQTT_TOPIC_MIN_BATTERY_VOLTAGE_TODAY_DF);
     this->initializeVariable(Variable::BATTERY_BOOST_VOLTAGE, "Boost volt.", VariableDatatype::DT_FLOAT, VariableUOM::UOM_VOLT, VariableSource::SR_STATS, VariableMode::MD_READWRITE, vPIN_BATTERY_BOOST_VOLTAGE_DF, MQTT_TOPIC_BATTERY_BOOST_VOLTAGE_DF);
Bettapro commented 1 year ago

Thanks @theaudio, I'll apply your fix.