Bettehem / ts3-musicbot

TS3 Music Bot with Spotify, YouTube, SoundCloud and Bandcamp support!
https://gitlab.com/Bettehem/ts3-musicbot
GNU General Public License v3.0
57 stars 11 forks source link

Option to customize commands and control volume for YT/SC #2

Closed quorraa closed 3 years ago

quorraa commented 3 years ago

Hello, first of all thank you for this bot! I learned a lot while setting it up as I wasn't as experienced with Linux distros but I have one little issue with it.

I'm wondering if there is any way to change the original commands, my friends and I are used to !play or -play instead of %queue-play and the same with %queue-add could be !add or -add. I would imagine it could be doable but it would depend if you cant have them because of a conflict with regex or something.

Also I can change the volume with no problem on Spotify but when YouTube links are added they blow everyone's ears off, im gonna assume that would be the same with soundcloud as it would play from a hidden browser where I got no way of controlling the volume. Is there a config file or a place where the volume could be hard coded before the bot starts?

Bettehem commented 3 years ago

Hello, thanks for trying out the bot! I have thought of adding configurable command names but haven't yet done it because nobody had requested it yet!

And yeah, the issue you described with setting YouTube/SoundCloud playback volume should be addressed too. Currently the only way to set the volume is by starting a YT/SC song and then while it's playing and then using pavucontrol/ncpamixer or equivalent to change the volume for the MPV media player which is used for playing YT/SC songs.

I just checked and it's actually possible to set the volume for mpv using the --volume flag, so I will add the possibility to configure the volume in a more straightforward way in the near future.

Bettehem commented 3 years ago

Anyways thanks for the feedback and let me know if you find some more problems, improvement suggestions etc. and I'll try to help.

EDIT: I suggest you to create future issues on the project's GitLab site, as that's where I mainly do my development stuff nowadays so I usually notice new issues there a bit faster than over here.

quorraa commented 3 years ago

Awesome! Your bot is great and I thank you for your time.

Thanks for the tip with pavucontrol, ill do that today.

I couldn't seem to find where to add an issue on gitlab so I came here. I'll look with detainment there for future comments, ideas.

Bettehem commented 3 years ago

Okay cool! You can find the issues page here.

Bettehem commented 3 years ago

Hello, @quorraa even though you already closed this issue, I thought I should let you know that I have now added a possibility to configure MPV's volume in the latest release.

Bettehem commented 3 years ago

Hello there, I have now further addressed the suggestions you had in this issue, adding support for command customization! I made a new release with these features added and instructions here.

quorraa commented 3 years ago

Thank you so much!