Bettensor / bettensor

Subnet repository for Bettensor, subnet 30 on the Bittensor network
https://bettensor.com
MIT License
7 stars 12 forks source link

Clear miner predictions when it's deregistered #49

Open ultrashiny opened 3 weeks ago

ultrashiny commented 3 weeks ago

check_hotkeys method in bettensor_validator.py detects changes in the hotkey list and clears scores for miners when they’re deregistered. However, reset_miner method in ScoringSystem doesn’t remove stored prediction data in the database for deregistered miners/hotkeys, which means this data persists.

This might affect a hotkey's score if it gets registered again. I recommend making an update to handle this:

ultrashiny commented 3 weeks ago

i might be wrong and please correct me if i'm mistaken

ultrashiny commented 2 weeks ago

https://github.com/Bettensor/bettensor/commit/e2766149434b2ac5b2d61ca4091e8eea6e4a0a85 i think, your new commit fixes this issue, @geardici what do you think?