Better-Conversations / bcf-flightplans-dsl

MIT License
0 stars 0 forks source link

Refine standardrb configuration #9

Closed simoncoles closed 1 month ago

simoncoles commented 2 months ago

After running standardrb --fix I still get this repeating error. I don't feel I understand this well enough to mess with it.

(base) simonc@Simons-15-MBA-225 ruby-flightplans % standardrb      
standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
  lib/bcf/flight_plans/dsl.rb:9:26: Lint/Syntax: unexpected token tAMPER (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:43:7: Lint/Syntax: unexpected token kEND (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:50:5: Lint/Syntax: unexpected token kEND (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:61:28: Lint/Syntax: unexpected token tAMPER (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:75:9: Lint/Syntax: unexpected token kEND (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:79:26: Lint/Syntax: unexpected token tAMPER (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:111:7: Lint/Syntax: unexpected token kEND (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
  lib/bcf/flight_plans/dsl.rb:116:5: Lint/Syntax: unexpected token kEND (Using Ruby 3.2 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
simoncoles commented 2 months ago

I've discarded some of what it wanted to do, @joshuacoles is better qualified to decide if what it wants is ok. So running it again will show more issues.

joshuacoles commented 2 months ago

I believe I have resolved this issue. It was due to misapplication of the Style/ArgumentsForwarding rule. I have disabled this rule for now