Better-HPC / keystone-api

Allocation management API for HPC systems.
0 stars 0 forks source link

Update celery task names to match python path after refactor #418

Closed Comeani closed 1 month ago

Comeani commented 1 month ago

Keystone's task logs report these tasks as erroring due to being unregistered after some recent refactoring of the tasks themselves.

Fixing their names in this way should cause the application to find them properly as registered again.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

djperrefort commented 1 month ago

@Comeani in two instances you updated the task name, and in one instance the task specification. The first two cases should not work. Did you test this PR in any way?

Comeani commented 1 month ago

I see what you're saying, that's my bad for not testing it like I should have. I can make another PR to make it all consistent and make an explicit test as well. Would it be sufficient to make sure the tasks here are registered or should the task specification already match the name?