Better-Scenes / RimConnect-mod

A Twitch integration for the game RimWorld
GNU General Public License v3.0
14 stars 8 forks source link

Add name of purchaser to ingame message #36

Closed AliceDTRH closed 2 years ago

AliceDTRH commented 2 years ago

I was wondering if this looked good so far.

AliceDTRH commented 2 years ago

Going to remove the has / have from the messages as well so it sounds better.

InfinitySamurai commented 2 years ago

Yeah that's looking fantastic, thank you so much! Seeing that if boughtBy == poll print this else print this stuff again makes me think it should be abstracted, it's used in a number of places. If you have any idea how we could do that ping me on discord and we can discuss. I'll have a think about it too

AliceDTRH commented 2 years ago

PR ready for review.

AliceDTRH commented 2 years ago

This PR is blocked by #28.

AliceDTRH commented 2 years ago

I think I implemented all requested changes unless I missed something?