search

Better-Scenes / RimConnect-mod

A Twitch integration for the game RimWorld
GNU General Public License v3.0
14 stars 8 forks source link

VFE Deserter error: "failed to provide valid commands to the server" #45

Open codeborgar opened 8 months ago

codeborgar commented 8 months ago

fails to 'post valid commands' to server with VFE Deserter on. Not my game, but a friend's

failvalidcommands

Kuuchuu commented 3 months ago

Extended error report from my fork with an extra debug line:

Failed to provide valid commands to server. Command Details: {"isError":false,"success":false,"message":"child \"validCommands\" fails because [\"validCommands\" at position 820 fails because [child \"description\" fails because [\"description\" must be a string]]]"}
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string)
RimConnection.RimConnectAPI:PostValidCommands (RimConnection.ValidCommandPayloadGenerator)
RimConnection.ServerInitialise:Init ()
RimConnection.ServerInitialise:.cctor ()
System.Runtime.CompilerServices.RuntimeHelpers:RunClassConstructor (System.RuntimeTypeHandle)
Verse.StaticConstructorOnStartupUtility:CallAll ()
Verse.PlayDataLoader/<>c:<DoPlayLoad>b__4_4 ()
Verse.LongEventHandler:ExecuteToExecuteWhenFinished ()
Verse.LongEventHandler:UpdateCurrentAsynchronousEvent ()
Verse.LongEventHandler:LongEventsUpdate (bool&)
Verse.Root:Update ()
Verse.Root_Entry:Update ()
Kuuchuu commented 3 months ago

Just submitted a pull request which should resolve the issue, but as I don't stream I can't do a full test. With pull request #53 RimConnect successfully provides commands to server and successfully connects to the server.

Kuuchuu commented 3 months ago

Specific problematic command is VFE Deserter's "missile rain". The Game Condition def "VFED_MissileRain" in VFE Deserter's 1.4/Defs/Misc/GameConditions.xml/1.5/Defs/Misc/GameConditions.xml does not have a description tag, which RimConnect requires. I've also gone ahead and submitted a bug report to VFE Deserter to see if I can get a description added for that game condition.