Open Erenthil opened 6 years ago
Sorry for the delay of response. For me, the token should not be included in the object VaultConfig as multiple users can use the same address/timeout/ssl config but will use different token.
A solution would be to implement a SessionManager that can be extended as it's the case for the Spring Vault project.
Here is my use case :
Can you talk a bit about the use case(s) here? The fundamental design of the driver thus far has been that tokens are tied to
VaultConfig
objects, and passed toVault
objects one time at construction. If you need to use multiple tokens, then you simply have multipleVault
objects.If someone is routinely using a variety of different tokens in the same area of code, then I could perhaps understand their preferences differing on that design. But I have to believe that this is an edge case rather than the typical norm, and breaking the existing pattern for it seems to be a bit muddled and confusing.