search

BetterCloud / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://bettercloud.github.io/vault-java-driver/
336 stars 223 forks source link

Made secretsEnginePathMap public #156

Closed gm2211 closed 5 years ago

gm2211 commented 5 years ago
  1. Made secretsEnginePathMap public
  2. Copying the map provided to secretsEnginePathMap - making it ConcurrentHashMap for consistency, though builders are usually modified within a single thread, so a concurrent hash map is not really necessary.
  3. Added convenience method putSecretsEngineVersionForPath for adding a single entry to the map

Also consider switching to https://immutables.github.io/ for builders - takes a lot of boiler-plate away and offers a lot of useful helper methods by default

abedra commented 5 years ago

:+1: please on this. It's currently impossible to set the secrets map if you add the option.

piotr-sumo commented 5 years ago

👍 I'd could find it extremely useful. Please merge this.

steve-perkins commented 5 years ago

Thanks @gm2211!