Bug in Pki.revoke() method - testing for incorrect HTTP response

BetterCloud / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault

https://bettercloud.github.io/vault-java-driver/

335 stars 224 forks source link

Bug in Pki.revoke() method - testing for incorrect HTTP response #160

Open ghost opened 5 years ago

ghost commented 5 years ago

The method revoke() throws a VaultException if it receives a HTTP status other than 200 (see lines 257-259) while the unit test asserts for a 204 response (see line 227). The REST API HTTP response is also 204.