Closed rabbitzzy closed 5 years ago
This is similar to https://github.com/BetterCloud/vault-java-driver/pull/164 which also support generic jwt.
This is similar to #164 which also support generic jwt.
Totally agree. Thank you! @mrunesson Do you know what is the integration and release schedule of this repo?
Unfortunately no idea.
On Mon, May 13, 2019, 00:07 Alex Zhu (AZ) notifications@github.com wrote:
This is similar to #164 https://github.com/BetterCloud/vault-java-driver/pull/164 which also support generic jwt.
Totally agree. Thank you! @mrunesson https://github.com/mrunesson Do you know what is the integration and release schedule of this repo?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BetterCloud/vault-java-driver/pull/171#issuecomment-491633409, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEY75XAKMHGE722JHTE33LPVCILBANCNFSM4HLMOGIA .
Thanks a lot @rabbitzzy! It looks like PR #164 basically provides the same functionality in a more generalized manner, so I'm getting ready to merge that one. Appreciate the contribution, however!
Thanks a lot! May I know when can we expect this feature ready to use after the merge?
On Mon, Jun 3, 2019 at 1:36 PM Steve Perkins notifications@github.com wrote:
Thanks a lot @rabbitzzy https://github.com/rabbitzzy! It looks like PR
164 https://github.com/BetterCloud/vault-java-driver/pull/164
basically provides the same functionality in a more generalized manner, so I'm getting ready to merge that one. Appreciate the contribution, however!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BetterCloud/vault-java-driver/pull/171?email_source=notifications&email_token=AB7JFFMCCA6EV35SEEWPGJDPYV6DTA5CNFSM4HLMOGIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2TX5Y#issuecomment-498416631, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7JFFK4BU7POMSTREUBOG3PYV6DTANCNFSM4HLMOGIA .
-- Zhenyan
@rabbitzzy: I'm making a pass through the backlog of outstanding PR's, and hope to have a Maven Central update out tomorrow or Wednesday. Whether it's a minor version or a major version bump depends on whether there are any breaking API changes, so I'm not sure yet what the actual artifact version will be.
Sorry, this Maven Central release is taking longer than I had hoped. One of the other PR's that I merged, #165, was supposed to add support for Java 9+ while maintaining compatibility with Java 8. Unfortunately, there was a misunderstanding, as I believed the library could still be built in a Java 8 environment. That turns out not to be true... the library now needs JDK 9+ on the build server to publish (I might have held off until the next release if I had fully grokked that).
I'll need to make some updates to the build environment tomorrow to support a newer version (11 LTS, probably), and cross my fingers that there aren't any issues importing the resulting library into a Java 8 test project (in which case I'd have to roll this back, as I'm not yet ready to drop support for the most widely-used Java version by a large margin).
FYI... I have a StackOverflow question open, to resolve the build issues that have prevented this latest version from going out. If anyone has any insights on this, that would be great:
I have resolved the build issues relating to Java 8 / 9+ compatibility, and updated the documentation for a 4.1.0 release. There are just some flaky integration tests standing between here and that publication.
Since this PR is closed, please see issue #170 for further updates.
This PR is to implement the vault auth for kubernetes mentioned in https://github.com/BetterCloud/vault-java-driver/issues/170, please letme know if any questions. thanks!