Logging is done through System.out.println

BetterCloud / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault

https://bettercloud.github.io/vault-java-driver/

335 stars 224 forks source link

Logging is done through System.out.println #177

Closed arngrimur-seal closed 5 years ago

arngrimur-seal commented 5 years ago

Logging using System.out.println is bad. It is not possible to filter and spams the test and production logs. Use java.util.logging (or better slf4j) instead of println for logging. This enables configurable logging and will still keep the project dependency free.

steve-perkins commented 5 years ago

Agreed. The associated PR has been merged, and I've updated the README to reflects its inclusion in the (still pending) 4.2.0 release.