make x-vault-token optional, allows using Vault Agent

BetterCloud / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault

https://bettercloud.github.io/vault-java-driver/

336 stars 223 forks source link

make x-vault-token optional, allows using Vault Agent #184

Closed jetersen closed 5 years ago

jetersen commented 5 years ago

fixes #183

Added a vault agent test container to validate the fix.

jetersen commented 5 years ago

@steve-perkins @steve-perkins-bc anything I can help to speed this up? Do you need someone to help maintain the repo?

jetersen commented 5 years ago

I wonder if it would help to rewrite the optionalHeader to be the default implementation. Currently, if header is given a null value the java library will throw 400 Bad request.

steve-perkins commented 5 years ago

Thanks, @casz!