search

BetterCloud / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://bettercloud.github.io/vault-java-driver/
336 stars 223 forks source link

[Documentation] Constructor of VaultConfig no longer accepts parameters #66

Closed Naktibalda closed 7 years ago

Naktibalda commented 7 years ago

In v3.0.0 constructor of VaultConfig no longer accepts parameters.

Result: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: com.bettercloud.vault.VaultConfig(java.lang.String, java.lang.String)

However the first 2 examples in documentation still use constructor parameters https://github.com/BetterCloud/vault-java-driver/blob/v3.0.0/README.md#initializing-a-driver-instance

final VaultConfig config = new VaultConfig("http://127.0.0.1:8200", "3c9fd6be-7bc2-9d1f-6fb3-cd746c0fc4e8");

// You may choose not to provide a root token initially, if you plan to use
// the Vault driver to retrieve one programmatically from an auth backend.
final VaultConfig config = new VaultConfig("http://127.0.0.1:8200");
steve-perkins commented 7 years ago

Thanks! An update has been merged into master. Since this is just a README change, this issue is effectively resolved since it's visible on the GitHub repo page right now.