BetterErrors / better_errors

Better error page for Rack apps
MIT License
6.88k stars 437 forks source link

Deprecate REPL::Pry, recommend separate gem #400

Open RobinDaugherty opened 7 years ago

RobinDaugherty commented 7 years ago

In the Better Errors project, we run tests against:

It's a massive matrix. A build takes 90-180 minutes. Some of these combinations are currently broken (or at least the tests are broken) and need some attention.

By extracting REPL::Pry into a separate gem, we can reduce the size of this matrix and add more test coverage for different versions of Pry and addon gems such as pry-backtrace without making the Better Errors test builds even worse.

At this time, there is no API for an external gem to cleanly inject itself into BE. Activating Pry support requires a line of code in the project which is called at project initialization. We need to be able to declare a plugin and allow it to register with BE at the right time in the lifecycle.

For backward compatibility, we need to still support the existing method of activating Pry support in BE. So the release of Better Errors that implements this would need to:

We might also want to look for the presence of Pry and emit a message at startup suggesting that better_errors-pry be installed.