search

BetterErrors / better_errors

Better error page for Rack apps
MIT License
6.88k stars 437 forks source link

Allows expanding the visible lines of code (Fixes #370) #409

Closed zedtux closed 2 years ago

zedtux commented 6 years ago

This PR implements the "Expand" icons like in Github (see #370). Clicking an expander calls the backend which returns only the code to be updated in the .code div so that the reste of the page stays as it is (no reset of the REPL).

Here is a preview:

screen shot 2017-11-16 at 10 05 18

After having clicked the top expander:

screen shot 2017-11-16 at 10 05 56

zedtux commented 6 years ago

@charliesome can I draw your attention to this PR?

zedtux commented 6 years ago

Thank you @RobinDaugherty for your review, I'm my code now.

zedtux commented 6 years ago

@RobinDaugherty the code has been updated. Please feel free to review it

zedtux commented 6 years ago

@RobinDaugherty can you please review my code?

RobinDaugherty commented 6 years ago

Sorry @zedtux I'm not able to answer quickly, but I'm able to spend time on this project once a week or so.

zedtux commented 6 years ago

Thank you @RobinDaugherty for your message, I'm available when you will be :)

zedtux commented 6 years ago

@RobinDaugherty a gentle reminder for my PR :)

zedtux commented 6 years ago

@RobinDaugherty and @charliesome a gentle reminder on this PR. I really think it's useful so I'm available for changing anything and get this thing merged :)

zedtux commented 6 years ago

@RobinDaugherty sorry for being asking again and again but can you please check the PR and let me know if there is anything I should change? Thank you.

zedtux commented 6 years ago

@RobinDaugherty can you please review this PR?

zedtux commented 6 years ago

@RobinDaugherty can you please review my PR?

zedtux commented 6 years ago

@RobinDaugherty can you please review my PR?

zedtux commented 6 years ago

Can you please have a look @RobinDaugherty? This is really useful in my day to day work.

zedtux commented 6 years ago

@RobinDaugherty please, have a look at this PR, the changes have been made and should be fine to be merged.

zedtux commented 6 years ago

@charliesome and @RobinDaugherty can you please have a look at my PR?

zedtux commented 6 years ago

@charliesome and @RobinDaugherty can you please have a look at my PR?

zedtux commented 6 years ago

@charliesome and @RobinDaugherty can you please have a look at my PR?

zedtux commented 6 years ago

Well ... it's now a long time ago I have oped this PR, with a review from @RobinDaugherty, who's now ignoring me and my PR ... What's the solution in order to get this merged? cc @charliesome

zedtux commented 6 years ago

@RobinDaugherty ?

zedtux commented 2 years ago

Really interesting the way this PR goes. Whatever ...