search

BetterErrors / better_errors

Better error page for Rack apps
MIT License
6.88k stars 437 forks source link

BetterErrors::Middleware.allow_ip! being ignored #442

Closed ate-it closed 5 years ago

ate-it commented 5 years ago

Ruby: 2.6.3 Rails: 6.0.0.rc2

I define BetterErrors::Middleware.allow_ip! "0.0.0.0/0" in config/development.rb (I did have a smaller scope but for the sake of testing). Yet better errors appear to ignore this:

Cannot render console from 10.10.1.103! Allowed networks: 127.0.0.1, ::1, 127.0.0.0/127.255.255.255

ate-it commented 5 years ago

Turns out I had config.consider_all_requests_local = false set.

This needed to be config.consider_all_requests_local = true

RobinDaugherty commented 5 years ago

Thanks @JackWetson I've updated the documentation to reflect that consider_requests_local must be enabled.